936080 - Tapping download notification crashes all Fennecs on device

Status: RESOLVED DUPLICATE of bug 934345

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Richard Newman [:rnewman]]

Notification generated from current Release (downloading a new Nightly). Tapping it (APK download) prompts the install dialog... and crash dialogs for every Firefox on the machine.

(a) These intents should probably only be caught by the downloading Firefox -- they should be package-limited.

(b) They shouldn't cause a crash.

E/AndroidRuntime(15577): FATAL EXCEPTION: main
E/AndroidRuntime(15577): java.lang.RuntimeException: Error receiving broadcast Intent { act=helperBroadcastAction dat=moz-notification:?eventType=notification-clicked&id=download%3A%2F%2F%2Fmnt%2Fsdcard%2FDownload%2Ffennec-28.0a1.multi.android-arm.apk&cookie=HEGCPHhF4Sv9 bnds=[0,289][540,385] (has extras) } in org.mozilla.gecko.NotificationHelper$1@4053b588
E/AndroidRuntime(15577): 	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:724)
E/AndroidRuntime(15577): 	at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime(15577): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime(15577): 	at android.os.Looper.loop(Looper.java:130)
E/AndroidRuntime(15577): 	at android.app.ActivityThread.main(ActivityThread.java:3906)
E/AndroidRuntime(15577): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(15577): 	at java.lang.reflect.Method.invoke(Method.java:507)
E/AndroidRuntime(15577): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:840)
E/AndroidRuntime(15577): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:598)
E/AndroidRuntime(15577): 	at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime(15577): Caused by: java.lang.NullPointerException
E/AndroidRuntime(15577): 	at org.mozilla.gecko.NotificationHelper.hideNotification(NotificationHelper.java:318)
E/AndroidRuntime(15577): 	at org.mozilla.gecko.NotificationHelper.handleNotificationIntent(NotificationHelper.java:152)
E/AndroidRuntime(15577): 	at org.mozilla.gecko.NotificationHelper.access$100(NotificationHelper.java:29)
E/AndroidRuntime(15577): 	at org.mozilla.gecko.NotificationHelper$1.onReceive(NotificationHelper.java:106)
E/AndroidRuntime(15577): 	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:711)
E/AndroidRuntime(15577): 	... 9 more
I/gralloc (  546): Allocated 0x660072 size 6488161
E/AndroidRuntime(14587): FATAL EXCEPTION: main
E/AndroidRuntime(14587): java.lang.RuntimeException: Error receiving broadcast Intent { act=helperBroadcastAction dat=moz-notification:?eventType=notification-clicked&id=download%3A%2F%2F%2Fmnt%2Fsdcard%2FDownload%2Ffennec-28.0a1.multi.android-arm.apk&cookie=HEGCPHhF4Sv9 bnds=[0,289][540,385] (has extras) } in org.mozilla.gecko.NotificationHelper$1@4053bdb8
E/AndroidRuntime(14587): 	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:724)
E/AndroidRuntime(14587): 	at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime(14587): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime(14587): 	at android.os.Looper.loop(Looper.java:130)
E/AndroidRuntime(14587): 	at android.app.ActivityThread.main(ActivityThread.java:3906)
E/AndroidRuntime(14587): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(14587): 	at java.lang.reflect.Method.invoke(Method.java:507)
E/AndroidRuntime(14587): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:840)
E/AndroidRuntime(14587): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:598)
E/AndroidRuntime(14587): 	at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime(14587): Caused by: java.lang.NullPointerException
E/AndroidRuntime(14587): 	at org.mozilla.gecko.NotificationHelper.hideNotification(NotificationHelper.java:323)
E/AndroidRuntime(14587): 	at org.mozilla.gecko.NotificationHelper.handleNotificationIntent(NotificationHelper.java:153)
E/AndroidRuntime(14587): 	at org.mozilla.gecko.NotificationHelper.access$100(NotificationHelper.java:29)
E/AndroidRuntime(14587): 	at org.mozilla.gecko.NotificationHelper$1.onReceive(NotificationHelper.java:107)
E/AndroidRuntime(14587): 	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:711)
E/AndroidRuntime(14587): 	... 9 more
E/AndroidRuntime(15614): FATAL EXCEPTION: main
E/AndroidRuntime(15614): java.lang.RuntimeException: Error receiving broadcast Intent { act=helperBroadcastAction dat=moz-notification:?eventType=notification-clicked&id=download%3A%2F%2F%2Fmnt%2Fsdcard%2FDownload%2Ffennec-28.0a1.multi.android-arm.apk&cookie=HEGCPHhF4Sv9 bnds=[0,289][540,385] (has extras) } in org.mozilla.gecko.NotificationHelper$1@405313e8
E/AndroidRuntime(15614): 	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:724)
E/AndroidRuntime(15614): 	at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime(15614): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime(15614): 	at android.os.Looper.loop(Looper.java:130)
E/AndroidRuntime(15614): 	at android.app.ActivityThread.main(ActivityThread.java:3906)
E/AndroidRuntime(15614): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(15614): 	at java.lang.reflect.Method.invoke(Method.java:507)
E/AndroidRuntime(15614): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:840)
E/AndroidRuntime(15614): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:598)
E/AndroidRuntime(15614): 	at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime(15614): Caused by: java.lang.NullPointerException
E/AndroidRuntime(15614): 	at org.mozilla.gecko.NotificationHelper.hideNotification(NotificationHelper.java:269)
E/AndroidRuntime(15614): 	at org.mozilla.gecko.NotificationHelper.handleNotificationIntent(NotificationHelper.java:132)
E/AndroidRuntime(15614): 	at org.mozilla.gecko.NotificationHelper.access$100(NotificationHelper.java:29)
E/AndroidRuntime(15614): 	at org.mozilla.gecko.NotificationHelper$1.onReceive(NotificationHelper.java:104)
E/AndroidRuntime(15614): 	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:711)

Comment 2

[Richard Newman [:rnewman]]

Attachment: Part 1: safety. v1

Untested.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 828769 [details] [diff] [review]
Part 1: safety. v1

No wallpaper :) We're going to fix this by not building a NotificationHelper in Services that don't need it.