936121 - Add Hamachi support to Eideticker

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

We want to be able to run eideticker against the Hamachi. This bug is meant to track any work needed to make this happen.

Comment 1

[Mandyam Vikram]

William, are any changes needed in Eideticker to support a different device? Any luck working on this?

Comment 2

[William Lachance (:wlach)]

(In reply to Mandyam Vikram from comment #1)
> William, are any changes needed in Eideticker to support a different device?
> Any luck working on this?

Yes, we need to add support to Orangutan (the input simulator) for the Hamachi. Ordinarily this wouldn't be that difficult, but it looks like this particular device has some peculiarities. I've been sidetracked on another high priority project but I hope to have a look at this Thursday or Friday.

Comment 3

[William Lachance (:wlach)]

Attachment: 0001-Bug-936121-Eideticker-support-for-hamachi-r-davehunt.patch

Trivial patch to add necessary bit to eideticker harness to support hamachi.

Comment 4

[William Lachance (:wlach)]

So with the patch here and in bug 936120, the Hamachi is now working with Eideticker. Just need to get sign off from davehunt on my patches and we're good to go.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8336397 [details] [diff] [review]
0001-Bug-936121-Eideticker-support-for-hamachi-r-davehunt.patch

Looks good.

Comment 6

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/eideticker/commit/c5ef2cb

Comment 7

[Mandyam Vikram]

That's great. 
Can we make another run using a build for which numbers have been published to re-calibrate our results?

Comment 8

[William Lachance (:wlach)]

(In reply to Mandyam Vikram from comment #7)
> That's great. 
> Can we make another run using a build for which numbers have been published
> to re-calibrate our results?

Yes. I would like to wait until Dave resolves bug 937730 (and its dependencies) so we have a consistent set of results to work from.