936164 - ouija slave view should only show slaves that have >5 jobs

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

this is a measure that will help us turn the long list of failed slaves into action items.  A slave that has run 2 jobs and failed both might not be a bad slave- it isn't causing a lot of noise.

Comment 1

[akruglov]

Attachment: 0001-Bug-936164.patch

Comment 2

[akruglov]

Attachment: 0002-Bug-936164.patch

Ah, sorry, the idea with filtering slaves on database level was not that good. Platform failure rate calculation gone bad, so I re-wrote code, and now it seems to be ok.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 828898 [details] [diff] [review]
0002-Bug-936164.patch

Review of attachment 828898 [details] [diff] [review]:
-----------------------------------------------------------------

great addition. is there any issues with the show all slaves checkbox?  I would be fine having limitations with that feature in order to get something more beneficial like this patch.

::: src/server.py
@@ +177,5 @@
> +    else:
> +        jobs = int(round(days_to_show * 0.4))
> +
> +    info = '''Only slaves with more than %d jobs are displayed.''' % jobs
> +

excellent!

@@ +184,5 @@
>      cursor.execute("""select slave, result, date from testjobs
>                        where result in
>                        ("retry", "testfailed", "success", "busted", "exception")
> +                      and date between "{0}" and "{1}"
> +                      order by slave;""".format(start_date, end_date))

I am unfamiliar with this use of format vs %.  I assume this is better for database connections?

Comment 4

[akruglov]

Well, if this patch will be applied, then only slaves with more than 5 jobs will be returned. So, if among those slaves will be slaves with no failures, checkbox will continue to work as expected, if there will be no such slaves, then there is nothing to show.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

dminor: I would like to apply this patch and roll it out.  I am not that familiar with the deployment solution.

Comment 6

[Dan Minor [:dminor]]

:jmaher, I'll apply this patch to make sure I get the steps right, and leave it here for future reference, until there is a better place for this information.

1) wget <patch url from bugzilla>
2) git am <patch>
3) sudo apachectl restart
4) check that it works :)
5) git push origin master

Revision: https://github.com/dminor/ouija/commit/1e1c277cd8d4e34c7d0642e4b5c733be6ea272b1

Comment 7

[akruglov]

This was done. Should we close ticket?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

oops, my bad, lets close this out!