When I chose print in Linux, the print dialog comes up. This dialog is modal as expected. However, when you accidentially click into the parent window (the browser window), the print dialog is moved behind the browser window, it's now hidden, and the normal user will be confused, as the application seems to no longer responsive. Expected behaviour: Dialog stays always on top of browser window. See bug 90997.
Adding patch, review keywords. Requesting review.
Status: NEW → ASSIGNED
Keywords: patch, review
Do you just need a review, or do you want this checked in also.
Would be great if you could check it in for me, as I don't have yet permissions. Thanks.
Thanks for r=. I'm meanwhile able to check in myself, so I can do it, once we have sr=.
Looks ok, but I really don't know this code...
Looks fine to me, but can't we factor that code that is repeated for every platform into a generic helper method? It looks to be platform neutral. Maybe a helper routine called GetDialogParent or something. Also, what has been done to test this?
Windows and Mac the Dialog stays on top already.. so this is not an issue there.
To test it, go to a Linux machine, open a web page select print, the print dialog comes up, now click in the browser contents. If the print dialogs hides, you see the bug. If the print dialog stays on top of the browser window, it is fixed. I see already more code duplication in these four files, for example the function GetPageDimensions. I suggest to make the wish for reducing code duplication a separate bug, to speed up landing of this fix. But feel free to attach a modified patch! However, I already asked for superreview, and this work will be useless when we attach a new patch. So personally I'd prefer a new bug.
sr=attinasi under the assumption that the test suggested by Kai has actually been performed (I do not have time to patch/build/test this change myself, sorry).
a=asa on behalf of firstname.lastname@example.org
Patch checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
verified in 10/2 linux build. looks like it works now....I simply print any page and then give the browser window focus, the print dialog stays on top like it should.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.