936202 - adding a contact triggers a list sync reflow due to imgLoader.reload()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently, when a contact is added or modified we end up calling imgLoader.reload() in addToList().  This is an issue for two reasons:

  1) The call to imgLoader.reload() triggers a sync reflow on the list.
  2) This gets called once for each contact added during a large import.

To avoid this situation we can defer the imgLoader.reload() until the visibility monitor detects a change that effects our current onscreen view.  Since the visibility monitor is smart enough to ignore contacts added below the current screen, this avoids a lot of sync reflows.

(We might want to open another bug to replace imgLoader altogether in favor of performing the logic from visibility monitor.)

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/13487

Jose, this pull request avoids a large number of sync reflows during the import process.  It does this by deferring the imgLoader.reload() call until the visibility monitor confirms that our onscreen view has been modified.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Note, this also includes not calling FixedHeader.refresh() in addToList().  This call is not needed here because the header is refreshed in showGroupByList().  This also helps with imports since performing the query selector on large DOM lists for each contact can get slow.

Comment 3

[Jose Manuel Cantera]

Please, nom it to 1.3 if you consider it

thanks

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Thanks for the review.  Travis is green except for an unrelated marionette failure in media playback.  Landed:

  https://github.com/mozilla-b2g/gaia/commit/dcdf1c525be784eb506ab06c523f5b0ef9b461d6

Jose, since master is 1.3, what does nom'ing for 1.3? do right now?