Closed
Bug 936278
Opened 11 years ago
Closed 11 years ago
Make mochitest chunk options work with `./mach mochitest-remote`
Categories
(Testing :: Mochitest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: jld, Assigned: jld)
Details
Attachments
(1 file, 1 obsolete file)
2.07 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
The chunk-related options aren't passed through correctly when running `./mach mochitest-remote`, so chunked tests can't be done that way (and, for reasons I'm not clear on, trying to run all the tests at once without chunking hangs and times out partway through).
It looks like some of the options need to be translated from snake_case to camelCase when being copied from run_b2g_test's kwargs to the chunk options. I've attached a patch that does this for the chunk-related options, but on further inspection it looks like most or all of the argument list and assignments from run_desktop_test should be copied instead. Suggestions?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jld
Assignee | ||
Comment 1•11 years ago
|
||
Fixed patch so it handles the kwargs/options that run_b2g_test will actually get.
Attachment #828980 -
Attachment is obsolete: true
Attachment #8335857 -
Flags: review?(jgriffin)
Comment 2•11 years ago
|
||
Comment on attachment 8335857 [details] [diff] [review]
bug936278-mochitest-remote-opts-hg0.diff
Review of attachment 8335857 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch!
Attachment #8335857 -
Flags: review?(jgriffin) → review+
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•