Make mochitest chunk options work with `./mach mochitest-remote`

RESOLVED FIXED in mozilla28

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla28
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 828980 [details] [diff] [review]
bugNNNNNN-mach-mochitest-chunkopts.diff

The chunk-related options aren't passed through correctly when running `./mach mochitest-remote`, so chunked tests can't be done that way (and, for reasons I'm not clear on, trying to run all the tests at once without chunking hangs and times out partway through).

It looks like some of the options need to be translated from snake_case to camelCase when being copied from run_b2g_test's kwargs to the chunk options.  I've attached a patch that does this for the chunk-related options, but on further inspection it looks like most or all of the argument list and assignments from run_desktop_test should be copied instead.  Suggestions?
(Assignee)

Updated

5 years ago
Assignee: nobody → jld
(Assignee)

Comment 1

5 years ago
Created attachment 8335857 [details] [diff] [review]
bug936278-mochitest-remote-opts-hg0.diff

Fixed patch so it handles the kwargs/options that run_b2g_test will actually get.
Attachment #828980 - Attachment is obsolete: true
Attachment #8335857 - Flags: review?(jgriffin)
Comment on attachment 8335857 [details] [diff] [review]
bug936278-mochitest-remote-opts-hg0.diff

Review of attachment 8335857 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!
Attachment #8335857 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 3

5 years ago
→ b2g-inbound.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/34cd985e104a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.