Closed
Bug 936291
Opened 11 years ago
Closed 11 years ago
WindowsError: [Error 145] The directory is not empty when doing mach clobber
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Unassigned)
References
Details
I just got mach clobber failing me twice in a row on different directories. Nothing was done to the objdir between those two runs:
$ ./mach clobber
Error running mach:
['clobber']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
WindowsError: [Error 145] The directory is not empty: u'c:\\Users\\mh\\mozilla-c
entral\\obj-i686-pc-mingw32\\toolkit\\mozapps\\extensions\\test'
File "c:\Users\mh\mozilla-central\python/mozbuild/mozbuild/mach_commands.py",
line 494, in clobber
self.remove_objdir()
File "c:\Users\mh\mozilla-central\python/mozbuild\mozbuild\base.py", line 287,
in remove_objdir
rmtree(self.topobjdir.encode('utf-8'))
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 161, in rmtree
os.rmdir(dir)
$ ./mach clobber
Error running mach:
['clobber']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
WindowsError: [Error 145] The directory is not empty: u'c:\\Users\\mh\\mozilla-c
entral\\obj-i686-pc-mingw32\\_tests\\xpcshell\\toolkit\\devtools\\apps'
File "c:\Users\mh\mozilla-central\python/mozbuild/mozbuild/mach_commands.py",
line 494, in clobber
self.remove_objdir()
File "c:\Users\mh\mozilla-central\python/mozbuild\mozbuild\base.py", line 287,
in remove_objdir
rmtree(self.topobjdir.encode('utf-8'))
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 156, in rmtree
rmtree(full_name)
File "c:\Users\mh\mozilla-central\testing/mozbase/mozfile\mozfile\mozfile.py",
line 161, in rmtree
os.rmdir(dir)
Reporter | ||
Updated•11 years ago
|
OS: Linux → Windows 7
Comment 1•11 years ago
|
||
Bug 861984 might fix this issue, though we would we need to synchronize the new mozfile rmtree method over from mozbase to mozilla-central for it to take effect.
(I could try doing this tomorrow if people think it'll help)
Comment 2•11 years ago
|
||
In any case, pushed changes to try: https://tbpl.mozilla.org/?tree=Try&rev=6b45f7cbaa6a
If this goes well, I'll bump mozfile versions and put up an m-c patch for review
Comment 4•11 years ago
|
||
Pretty sure this should be fixed. If someone with a Windows environment could verify, would be appreciated.
Comment 5•11 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #4)
> Pretty sure this should be fixed. If someone with a Windows environment
> could verify, would be appreciated.
Seems to fix the issue on my system, but I can't be 100% as it was intermittent :)
Comment 6•11 years ago
|
||
Given that we haven't heard any new failures for this in the past couple of months, I would say we close this bug as fixed. If someone still has a situation when it doesn't work, we might want to file a new bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•