Support new key names "GroupNext", "GroupPrevious", "GroupFirst" and "GroupLast" for keyboard layout switching key

RESOLVED FIXED in mozilla37

Status

()

Core
DOM: Events
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

For keyboard layout switching keys, new key names "GroupNext", "GroupPrevious", "GroupFirst" and "GroupLast" are defined.
Status: NEW → ASSIGNED
Created attachment 8445211 [details] [diff] [review]
Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk

These key are defined for GTK's ISO keys.

According to the definition of ISO,

http://en.wikipedia.org/wiki/ISO/IEC_9995#Groups

this works as switch of keyboard layouts. Therefore, I believe that AKEYCODE_LANGUAGE_SWITCH of Android should be "GroupNext".

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html#key-GroupFirst

http://developer.android.com/reference/android/view/KeyEvent.html#KEYCODE_LANGUAGE_SWITCH
>  public static final int KEYCODE_LANGUAGE_SWITCH
> Added in API level 14
> 
> Key code constant: Language Switch key. Toggles the current input language
> such as switching between English and Japanese on a QWERTY keyboard. On some
> devices, the same function may be performed by pressing Shift+Spacebar.
Attachment #8445211 - Flags: review?(nchen)
Attachment #8445211 - Flags: review?(mwu)
Attachment #8445211 - Flags: review?(karlt)
Attachment #8445211 - Flags: review?(bugs)
Attachment #8445211 - Flags: review?(nchen) → review+
Comment on attachment 8445211 [details] [diff] [review]
Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk

The _Group_Lock variants are not used in any xkeyboard-config layouts, even on layouts where the _Group keys lock the group.
Attachment #8445211 - Flags: review?(karlt) → review+

Updated

4 years ago
Attachment #8445211 - Flags: review?(mwu) → review+

Comment 3

4 years ago
Comment on attachment 8445211 [details] [diff] [review]
Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk

So if _Lock aren't actually used, perhaps no need to add them here.
Attachment #8445211 - Flags: review?(bugs) → review+
Created attachment 8446436 [details] [diff] [review]
Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk (r=nchen+karlt+mwu+smaug)

Okay, I removed GDK_*_Lock from the mapping table.
Attachment #8445211 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/3f542e61e7fa
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.