Closed Bug 936334 Opened 11 years ago Closed 11 years ago

[RIL] Need sharper error handling for mozIccManager.updateContact

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: kaze, Assigned: allstars.chh)

References

Details

When navigator.mozIccManager.updateContact() fails in Gaia, there’s currently no way to know if the operation has failed because of a wrong PIN2 code or because of an intrinsic issue (e.g. bug 936309): the event object that is passed to the `onerror' callback only has an { isTrusted: true } property.

Yoshi, can you attach more details to this error event please? For “PIN2 incorrect” messages, it’d be nice to have the number of remaining retries, too.
Assignee: nobody → allstars.chh
Blocks: 916059
Requesting koi+ as this bug blocks the dependent koi+ bug.
blocking-b2g: --- → koi?
(In reply to Fabien Cazenave [:kaze] from comment #0)
> it’d be nice to have the number of remaining retries,
> too.

Hi, Kaze
Just check ril.h, the modem doesn't pass the remaining retryCount for pin2 to RIL when updating FDN, so even RIL doesn't know the retryCount either.
(In reply to Fabien Cazenave [:kaze] from comment #0)
> When navigator.mozIccManager.updateContact() fails in Gaia, there’s
> currently no way to know if the operation has failed because of a wrong PIN2
> code or because of an intrinsic issue (e.g. bug 936309): the event object
> that is passed to the `onerror' callback only has an { isTrusted: true }
> property.
> 

Hi, Kaze 
But I can get the error messge from onerror

request.onerror = function (evt) {
  dump(evt.target.error.name);
  dump(request.error.name);
};

Both could get the errorMsg, although the message is 
"ICC I/O Error code IncorrectPassword EF id=.. command=.."

Can't you get this error message?
Or you can get the message, but you'd like to make the errorMsg more clear, like "IncorrectPassword" ?
Flags: needinfo?(kaze)
Correct. I didn’t use the proper property… shame on me. :-$
Sorry for the noise.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(kaze)
Resolution: --- → INVALID
blocking-b2g: koi? → ---
Blocks: 1157082
You need to log in before you can comment on or make changes to this bug.