Closed Bug 936336 Opened 6 years ago Closed 6 years ago

xpcom/build/PoisonIOInterposerMac.cpp: [-Wunused-private-field] private field 'mFd' is not used

Categories

(Core :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Fixed -Wunused-private-field warning from bug 902587 by removing unused private member variable MacIOAutoObservation::mFd.

xpcom/build/PoisonIOInterposerMac.cpp:98:23 [-Wunused-private-field] private field 'mFd' is not used
Attachment #829039 - Flags: review?(jopsen)
Comment on attachment 829039 [details] [diff] [review]
Wunused-private-field_mFd.patch

It looks sound, r+

Sorry about putting an unused field in there :)
It's a left over from when I split a patch in to multiple pieces, so I have a
patch to land later that will use this field. But go a head an remove it for
now, it might be a while before that patch lands anyway.
 - I have a little investigation to do first...
Attachment #829039 - Flags: review?(jopsen) → review+
https://hg.mozilla.org/mozilla-central/rev/9cd2d3182c4f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.