936346 - [fugu] Orientation metadata is ignored when editing a picture in gallery application

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Jesse]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.110 Safari/537.36

Steps to reproduce:

1. Lunch the Gallery application.

2. Select a picture which has orientation metadata , click the 'edit' button


Actual results:

The picture doesn't show properly.


Expected results:

The picture should been rotated if it has orientation metadata .

Comment 1

[Jesse]

Sorry for creating a bug with [fugu] tag，but that the problem is serious in our fugu devices.

All pictures have orientation metadata taken on fugu cameras.

Another bug is related to this one：

https://bugzilla.mozilla.org/show_bug.cgi?id=936344

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Jesse,

We do parse the metadata from picture[1]. There is a jpeg metadata parser in gaia. We use it at imagesize.js[2]. And imagesize.js is called at [3] to get the whole metadata. But that's jpeg.

We don't know which picture type you mentioned. But if you took a picture with built-in camera, it is jpeg.

[1] https://github.com/mozilla-b2g/gaia/blob/f58f86f5b49c8041d9bac46e3f8f421a2f524fa9/shared/js/media/jpeg_metadata_parser.js#L120
[2] https://github.com/mozilla-b2g/gaia/blob/f58f86f5b49c8041d9bac46e3f8f421a2f524fa9/apps/gallery/js/imagesize.js#L52
[3] https://github.com/mozilla-b2g/gaia/blob/f58f86f5b49c8041d9bac46e3f8f421a2f524fa9/apps/gallery/js/MetadataParser.js#L142

Comment 3

[Jesse]

I mean that "ImageEditor.js" in gallery doesn't handle exif metadata.

See "https://bugzilla.mozilla.org/show_bug.cgi?id=798684" for details.

Sorry for highlighting the bug for your attention.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Ok, Jesse. I got it. Yes, you are correct. We don't handle the writing of exif metadata correctly. When the bug 798684 landed, it will handle it correctly.

BTW, we are currently doing something about image rotation. After bug 891030 finished, I believe the handling of orientation field in exif metadata will be correct, but not the whole exif metadata which is dealt with 798684.

Comment 5

[Jesse]

Thanks. How long does it take to finish the bug 891030? It's urgent for us.

(In reply to John Hu [:johnhu] from comment #4)
> Ok, Jesse. I got it. Yes, you are correct. We don't handle the writing of
> exif metadata correctly. When the bug 798684 landed, it will handle it
> correctly.
> 
> BTW, we are currently doing something about image rotation. After bug 891030
> finished, I believe the handling of orientation field in exif metadata will
> be correct, but not the whole exif metadata which is dealt with 798684.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

I cannot tell you the exact time. It may help to put your "urgent" request there.

Comment 7

[James Zhang (Spreadtrum)]

koi?

Comment 8

[James Zhang (Spreadtrum)]

Hi John,
cc Keven Kuo,

    We need confirm whether this issue is koi?

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi James,

We don't have this feature in v1.2. That's the known issue from v1.1. That's why we have bug 798684.

cc hema to let her know this bug.

Comment 10

[Jason Smith [:jsmith]]

(In reply to John Hu [:johnhu] from comment #9)
> Hi James,
> 
> We don't have this feature in v1.2. That's the known issue from v1.1. That's
> why we have bug 798684.
> 
> cc hema to let her know this bug.

In that case, then this is a blocking-. We aren't taking features into 1.2 at this point.

Comment 11

[Hema Koka [:hema]]

(In reply to John Hu [:johnhu] from comment #4)
> Ok, Jesse. I got it. Yes, you are correct. We don't handle the writing of
> exif metadata correctly. When the bug 798684 landed, it will handle it
> correctly.
> 
> BTW, we are currently doing something about image rotation. After bug 891030
> finished, I believe the handling of orientation field in exif metadata will
> be correct, but not the whole exif metadata which is dealt with 798684.

Yes that's correct, 891030 will land in 1.3 and I have marked 798684 for 1.4. This shouldn't be a blocker for koi (1.2)

Comment 12

[Steven Yang [:styang]]

After discussed with our partner, it will not block fugu.

Comment 13

[BMO Automation]

Firefox OS is not being worked on