936365 - [shared] Intermittent Travis Unit test failure: [gallery] GestureDetector gesture detection mousehold N: Error: expected 'pan pan pan pan swipe' to match /holdstart (holdmove )*holdend/

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Aug 24)]

1) [gallery] GestureDetector gesture detection mousehold N:

Error: expected 'pan pan pan pan swipe' to match /holdstart (holdmove )*holdend/

at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:33)

at match (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:763)

at match (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1649)

at (anonymous) (http://gallery.gaiamobile.org:8080/test/unit/GestureDetector_test.js:326)

at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:40)

at checkhold (http://gallery.gaiamobile.org:8080/test/unit/GestureDetector_test.js:325)

Comment 2

[Kevin Grandon :kgrandon]

This test has been disabled: https://github.com/mozilla-b2g/gaia/commit/2c0bbff90338b436889dd2473f70be0147f6ca44

Djf - as this test has been disabled, I was wondering if you could help us find an owner for this one. We should make this high-priority to re-enable this test if we are still using this functionality. Thanks!

Comment 3

[David Flanagan [:djf]]

As far as I know, no one is using the hold event stuff from Gesture Detector. That was written back before we had working contextmenu events.  So I think it would be okay to remove those hold event tests  (and add a deprecation warning to the gesture detector maybe if it is invoked with holdEvents:true?)

All of the tests in this file have timing dependencies and have been flaky.  If anyone has figured out how to deal with time-sensitive tests, they might be a good person to overhaul this test suite.

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Aug 24)]

Yeah, I wanted to have a look at these tests for a long time already. I might do it this week (maybe not rewrite everything but at least have an idea on whether we can fix it or not).

Comment 5

[Armen [:armenzg]]

Closing all intermittent test failures for Firefox OS (since we're not focusing on it anymore).

Please reopen if my search included your bug by mistake.

Comment 6

[BMO Automation]

Firefox OS is not being worked on