936418 - [keyboard] 'Layout selection' in keyboard style switcher dialog isn't localized

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

apps/system/js/keyboard_manager.js:

ActionMenu.open(items, 'Layout selection', function(selectedIndex) {

"Layout selection" needs to be localized.

Comment 1

[Axel Hecht [:Pike]]

This is the titel of the menu when you long-press the keyboard globe to choose an alternative keyboard.

The string was introduced in bug 816912.

Comment 2

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/13558

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 829968 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/13558

r=me.

Gary, thank you.

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Landed in gaia master:
https://github.com/mpizza/gaia/commit/ff35da1e70028276510c39f7ebaa421a7acb3ade

Travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/13791971

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted ff35da1e70028276510c39f7ebaa421a7acb3ade to:
v1.2: 8281d33d5b068c9ae6e1ffc2bca485a48bcd72b9