936419 - [music2] [4] Implement the search

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Dominic Kuo [:dkuo]]

After the first item(Bug 936385) of music2 is landed, we can start to implement the search that the current music has.

This item should cover:
4-1. Activating.
4-2. Display and play the results.

Comment 1

[Jim Porter (:squib)]

Taking this, since I did search the last time around, so I know a bit about it.

Comment 2

[Dominic Kuo [:dkuo]]

Jim, I have landed Evan's first patch in bug 936385, it has done most parts of the basic ui so I think probably you can try to implement the search ui first after you rebase to the master, thanks!

Comment 3

[Jim Porter (:squib)]

Dominic: do you know if we're planning on animating the transitions between modes? This was one of the main issues with implementing the search UI the first time around, and it'll probably require some planning to get things right in music2 as well.

Comment 4

[Francis Lee [:frlee]]

this is subset of Music2 re-layout for tablet, tag it 1.3+ with target milestones.

Comment 5

[Dominic Kuo [:dkuo]]

(In reply to Jim Porter (:squib) from comment #3)
> Dominic: do you know if we're planning on animating the transitions between
> modes? This was one of the main issues with implementing the search UI the
> first time around, and it'll probably require some planning to get things
> right in music2 as well.

Currently no, but I think I can bring this topic to UX team and discuss with them, I will update the results here. And please let me know if there is some other things that blocking you, thanks.

Comment 6

[Dominic Kuo [:dkuo]]

Jim,

UX team has updated the spec in:
https://mozilla.app.box.com/s/8s2b3160bakhxqy6uhsc/1/1259365594
(Please see the latest one)
The part of search is also updated and you can take a look.

* Because the priority of flatfish is changed so let's sync with Hema first before we re-start to implement music2, thanks.

Comment 7

[Jim Porter (:squib)]

Closing all music2-specific bugs. The current plan is to gradually incorporate bits of music2 into the current music app, since it will take too long to achieve feature parity in music2.