Status

Webtools
DXR
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: erik, Assigned: espressive)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
As shown at https://wiki.mozilla.org/DXR_UI_Refresh#Initial_Page, the tree menu serves a dual purpose: (1) scoping the search and (2) changing the dir listing to a different tree. I'm not thrilled at how it sits in my wireframes: some of the feedback at the Summit indicates that the effect on the dir listing might be unexpected and confusing.

We could launch as-is, but if you have any better interaction design ideas, I'd love to draw on them. One thought that comes to mind is lifting the tree selector out of the search bar, making the search bar and the listing area visually subordinate to it. Let me know if you have any ideas. If not, we can push this off till after bug 860271; just remove the blocker.
(Assignee)

Updated

5 years ago
Assignee: nobody → schalk.neethling.bugs
Status: NEW → ASSIGNED
(Reporter)

Comment 1

5 years ago
I did a ton of thinking about this today and have a few updated wireframes to show you, Schalk. I think they make everything a lot clearer. They obsolete some of our existing work, but they also make some future work unnecessary. Perhaps I can get your input Monday. Have a great weekend!
(Reporter)

Comment 2

5 years ago
I've updated the wireframes at https://wiki.mozilla.org/DXR_UI_Refresh#Initial_Page and downward. Let me know what you think! I'm pretty excited about them right now, and the scope is adjustable (for example, the parallel-folder links don't have to ship initially), but I'm sure I'll hate it in the morning. ;-)
(Assignee)

Comment 3

5 years ago
(In reply to Erik Rose [:erik][:erikrose] from comment #1)
> I did a ton of thinking about this today and have a few updated wireframes
> to show you, Schalk. I think they make everything a lot clearer. They
> obsolete some of our existing work, but they also make some future work
> unnecessary. Perhaps I can get your input Monday. Have a great weekend!

Hey Erik,

I love it! I will get to work on implementing the changes ASAP.
(Reporter)

Comment 4

5 years ago
As we talked about in IRC, I'll implement the tree menu, since I already have time slotted to implement multi-tree bug fixes, and rethinking it in this way eliminates all the bugs. :-)

We can now take this bug to mean "Implement tree selector".
Assignee: schalk.neethling.bugs → erik
(Reporter)

Comment 5

5 years ago
Here, I drove a quick spike through the UI, which I wasn't at all sure would be do-able: https://github.com/erikrose/dxr/commit/93ed9e22b5e0bd6994ee2b0867fc755c7742ce7b. That right-justified menu was much harder than it should have been! I tried Chosen (which didn't support rich content in menu items) and Select2 (which didn't want to do right justification despite seeming to have attempts in its source) before giving up and writing my own. I don't think you'll have the same trouble with the Filters menu. For that, you might get away with Select2, or feel free to pick something else you like.
(Reporter)

Comment 6

4 years ago
Do you still want to grab this from me? Let me know if you're running out of time.
Summary: Reconsider presentation of tree selector → Implement tree selector
(Assignee)

Comment 7

4 years ago
(In reply to Erik Rose [:erik][:erikrose] from comment #6)
> Do you still want to grab this from me? Let me know if you're running out of
> time.

Nope I am all good to implement the UI bit for this.
(Reporter)

Updated

4 years ago
Assignee: erik → schalk.neethling.bugs
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 8

4 years ago
Commits pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/b951f6a89c9ee5a04a4fa4072adf93dc3f2b9a1f
Fix Bug 936492, implement tree selector for multi tree support

https://github.com/mozilla/dxr/commit/43e9f86ed5689f0865afe54aa3a18580f9755fb9
Merge pull request #210 from ossreleasefeed/multi-tree

Fix Bug 936492, implement tree selector for multi tree support
You need to log in before you can comment on or make changes to this bug.