Closed Bug 936495 Opened 11 years ago Closed 11 years ago

Reorder is-this-listener-added-already-to-ELM check

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: smaug, Assigned: smaug)

Details

(Whiteboard: [qa-])

Attachments

(2 files)

elm_reorder.diff
1.12 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
elm_reorder_2.diff
1.20 KB, patch
Details | Diff | Splinter Review
Attached patch elm_reorder.diff — — Splinter Review 
ls->mListener == aListener is not a pointer comparison these days.
Attachment #829310 - Flags: review?(bzbarsky)
Comment on attachment 829310 [details] [diff] [review]
elm_reorder.diff

r=me, but add a comment about how the aListener compare should be last?
Attachment #829310 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/791fe13b7966
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: