936505 - Neaten up test_settings_wallpaper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)

Description

[Florin Strugariu [:Bebe]]

Make test_settings_wallpaper use the Activities region
Get the wallpaper settings from the proper Pref rather than just the settings HTML

Comment 1

[Eduardo Stalinho [:eduardostalinho]]

I see the test using the settings HTML displayed on page, but what do you mean by Pref. How can I get it in the test?

Comment 2

[Zac C (:zac)]

I *think* this will be what you want!

It should be the same value as `display_settings.wallpaper_preview_src` but it comes from the proper preferences database so we will be checking that the Gaia app sets the value into the database properly.

self.marionette.execute_script("SpecialPowers.getBoolPref('wallpaper.image');", special_powers=True)

Comment 3

[Robert Chira [:RobertC]]

I will work on this bug

Comment 4

[Robert Chira [:RobertC]]

Attachment: Pull request

Comment 5

[Robert Chira [:RobertC]]

I did not understand the "Get the wallpaper settings from the proper Pref rather than just the settings HTML" part 

Running 
self.marionette.execute_script("SpecialPowers.getBoolPref('wallpaper.image');", special_powers=True) returns an error 

Did the "wallpaper.image" pref name change?

Comment 6

[Florin Strugariu [:Bebe]]

I found a setting: "wallpaper.image"

Maybe we can use that

Comment 7

[Robert Chira [:RobertC]]

Updated pull request to use the "wallpaper.image" setting which will fail if the images have the same size. 
The previous assertion would not fail if the same image is selected.

Comment 8

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8360449 [details] [review]
Pull request

See comments in the PR. I addition to some questions, the test is failing for me on b2g desktop.

Comment 9

[[:AndreiH]]

Comment on attachment 8360449 [details] [review]
Pull request

The test works nice, the code looks ok, but I have 1 comment that I want to be addressed.

Comment 10

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8360449 [details] [review]
Pull request

Looking good. Just a couple of comments left to address in the pull request.

Comment 11

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8360449 [details] [review]
Pull request

Looks good now. Just resolve the merge conflict and it will be ready to be merged. Leaving my r? to remind me to merge, unless someone else does it first.

Comment 12

[[:AndreiH]]

Comment on attachment 8360449 [details] [review]
Pull request

looks good!

Comment 13

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8360449 [details] [review]
Pull request

Landed in https://github.com/mozilla-b2g/gaia/commit/92d46c97f821ad3e4718b68cb62411b388bfd158