936544 - [e.me][bug] Cloudapps do not get deduped in Collections

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Cloudapp results which are equivalent to installed apps get deduped in e.me search results but not in Collections.

STR:
1. Install Facebook app from Marketplace.
2. Open "social" Collection.

Expected:
The Facebook cloudapp doesn't appear in results

Actual:
The Facebook cloudapp does appear in results

Doing the same when searching "social" yields the expected behavior.

Comment 1

[Amir Nissim (:amirn)]

Attachment: patch - redirect to github PR #13535

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Didn't work too well in some cases. I pushed a new version. Try it out.

Comment 3

[Amir Nissim (:amirn)]

updated PR, please review.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Found one dedup bug in installedApps-appUrls:

STR:
1. Search for "facebook"
2. Long press the "facebook" cloud app and "save to Homescreen"

Expected:
Cloud app appears above and not below

Actual:
Cloud app appears in both places

Reason:
The style rule has whitespace in the data-url
<style id="installedApps-appUrls">
    .evme-apps ul:not(.installed) li[data-url="http://m.facebook.com   "]{display:none}
</style>

Comment 5

[Amir Nissim (:amirn)]

the whitespace originates from the server response (only for facebook).

added trim() when creating grid items and updated PR.

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 829566 [details] [review]
patch - redirect to github PR #13535

Tested it a million ways! Works great.

Comment 7

[Cristian Rodriguez (:crdlc)]

Comment on attachment 829566 [details] [review]
patch - redirect to github PR #13535

Looks good to me, thanks

Comment 8

[Amir Nissim (:amirn)]

landed
https://github.com/mozilla-b2g/gaia/commit/900a9a4a579cda9a792ef3a5e6d5a0ef47e1cd09

Comment 9

[Jason Smith [:jsmith]]

Clearing nom - this is already part of 1.3, so this doesn't need to be triaged.