936566 - Print mask layers in layers dump

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 1

[Nick Cameron [:nrc]]

Comment on attachment 829398 [details] [diff] [review]
patch

Review of attachment 829398 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but the patch is kinda borked - it has the changes twice and not enough context.

::: gfx/layers/Layers.cpp
@@ +1270,5 @@
> +  if (mMaskLayer) {
> +    nsAutoCString pfx(aPrefix);
> +    pfx += "   \\ MaskLayer ";
> +    mMaskLayer->LogSelf(pfx.get());
> +  }

Can this block be in PrintInfo too? I don't see why it is separated off into LogSelf when we just called PrintInfo.

Comment 2

[Benoit Girard (:BenWa)]

Not for the formatting I want. The layer's will be [mMaskLayer=%p] and will be followed by the MaskLayer on the next line. So it needs to be after to get the new line.

Comment 3

[Nick Cameron [:nrc]]

(In reply to Benoit Girard (:BenWa) from comment #2)
> Not for the formatting I want. The layer's will be [mMaskLayer=%p] and will
> be followed by the MaskLayer on the next line. So it needs to be after to
> get the new line.

Fair enough, looks good as is.

Comment 4

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8015a52178

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ead5ffba89 for https://tbpl.mozilla.org/php/getParsedLog.php?id=30742594&tree=Mozilla-Inbound

Comment 6

[Benoit Girard (:BenWa)]

Attachment: patch v2

Comment 7

[Benoit Girard (:BenWa)]

Attachment: patch v3

forgot qref

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8f41da1da9

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d8f41da1da9