Transition in thumbnails on TopSites tiles

RESOLVED FIXED in Firefox 28

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sfoster, Assigned: sfoster)

Tracking

unspecified
Firefox 28
x86
Windows 8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
On slower machines/networks, when the TopSites tile thumbnails load there is still a subtle flicker effect as each one is switched in. Maybe fading them in would ease this experience?
(Assignee)

Comment 1

5 years ago
Created attachment 829437 [details] [diff] [review]
Fade out default thumbnail when customImage is set

Do either of you have a minute to take a look at this? The idea is to apply the default firefox watermark image to an :after element, which is then transitioned to opacity 0 when customImage is set and the new thumbnail background is applied to the element behind. 
It seems to improve the loading experience a bit for me, but its possible the additional compositing necessary might make things worse on other devices? If you think its a dubious idea or implementation I'm happy to WONTFIX the bug as otherwise I think we've done about all we can on this.
Assignee: nobody → sfoster
Attachment #829437 - Flags: feedback?(rsilveira)
Attachment #829437 - Flags: feedback?(mbrubeck)
Comment on attachment 829437 [details] [diff] [review]
Fade out default thumbnail when customImage is set

Review of attachment 829437 [details] [diff] [review]:
-----------------------------------------------------------------

I really like the effect. I hope that setting opacity to 0 removes the perf impact of the :after layer.
Attachment #829437 - Flags: feedback?(rsilveira) → feedback+
(Assignee)

Comment 3

5 years ago
Comment on attachment 829437 [details] [diff] [review]
Fade out default thumbnail when customImage is set

Making this a review request
Attachment #829437 - Flags: feedback?(mbrubeck) → review?(mbrubeck)
Comment on attachment 829437 [details] [diff] [review]
Fade out default thumbnail when customImage is set

Review of attachment 829437 [details] [diff] [review]:
-----------------------------------------------------------------

Performs well on my X1 at least.  Sometime soon we should profile the whole about:start load/transition and see what needs optimizing.
Attachment #829437 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/b49bb9abcb8c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.