Closed
Bug 936627
Opened 11 years ago
Closed 11 years ago
Remove the border around the arrowpopup
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird26 fixed, thunderbird27 fixed, thunderbird_esr2426+ fixed)
RESOLVED
FIXED
Thunderbird 28.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
9.14 KB,
image/png
|
Details | |
884 bytes,
patch
|
jsbruner
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
standard8
:
approval-comm-esr24+
|
Details | Diff | Splinter Review |
Bug 883506 didn't remove a rule which is causing a border and tooltip background around the arrowpanel. This bug is to remove it now.
Assignee | ||
Comment 1•11 years ago
|
||
remove it
Comment 2•11 years ago
|
||
Comment on attachment 829481 [details] [diff] [review]
patch
Review of attachment 829481 [details] [diff] [review]:
-----------------------------------------------------------------
I can't actually test this, (facing Windows build problems now), but the code looks fine. r+ assuming it works. ;)
Attachment #829481 -
Flags: review?(josiah) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 829481 [details] [diff] [review]
patch
[Approval Request Comment]
Regression caused by (bug #): 883506
User impact if declined: weird appearance
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low, only a CSS change
Attachment #829481 -
Flags: approval-mozilla-esr24?
Attachment #829481 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 829481 [details] [diff] [review]
patch
Wrong approval flag chosen.
Attachment #829481 -
Flags: approval-mozilla-esr24? → approval-comm-esr24?
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
Comment 6•11 years ago
|
||
Comment on attachment 829481 [details] [diff] [review]
patch
[Triage Comment]
a=Standard8
Attachment #829481 -
Flags: approval-comm-esr24?
Attachment #829481 -
Flags: approval-comm-esr24+
Attachment #829481 -
Flags: approval-comm-beta+
Attachment #829481 -
Flags: approval-comm-aurora?
Attachment #829481 -
Flags: approval-comm-aurora+
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/8dc81fc71ee1
https://hg.mozilla.org/releases/comm-beta/rev/cddecac7f06d
status-thunderbird26:
--- → fixed
status-thunderbird27:
--- → fixed
tracking-thunderbird_esr24:
--- → 26+
Comment 8•11 years ago
|
||
status-thunderbird_esr24:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•