936639 - [Messages][Drafts] Create Drafts object + tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Evelyn Eastmond [:evhan55]]

Create a Drafts object:

* contains a list of draft objects
* length
* push
* filter
* forEach
* delete

Comment 2

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/13756

- Drafts Singleton
    - Adds, deletes, clears Draft objects
    - Loads and stores Draft objects from storage
    - Fetches all Draft objects for a thread id
- Drafts.List object
    - Array-list holder for Draft objects
    - has readonly accessor for length
    - has forEach to run callback on all contained Draft objects
- Draft object
    - standalone class to describe fields for a Draft instance
- Tests
    - Drafts: unit tests for adding, deletion, clearing, storing, loading, fetching by id
    - Draft.List: unit tests for length, forEach
    - Draft: no unit tests yet

Comment 3

[Rick Waldron [:rwaldron]]

Comment on attachment 833097 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13756

Needs to be broken into two PRs:

- Bug 936639
- Bug 931083

Comment 4

[Evelyn Eastmond [:evhan55]]

Comment on attachment 833097 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13756

Resubmitting for review:

Removed all storage code and put back in it's own PR.
New PR comment:

- Drafts Singleton
    - Adds, deletes, clears Draft objects
    - Fetches all Draft objects for a thread id
- Drafts.List object
    - Array-like holder for Draft objects
    - has readonly accessor for length
    - has forEach to run callback on all contained Draft objects
- Draft object
    - standalone class to describe fields for a Draft instance
- Tests
    - Drafts: unit tests for adding, deleting, clearing, fetching by id
    - Draft.List: unit tests for length, forEach
    - Draft: no unit tests yet

Comment 5

[Evelyn Eastmond [:evhan55]]

New PR comment:

- Drafts Singleton
    - Adds, deletes, clears Draft objects
    - Fetches all Draft objects for a thread id
- Drafts.List object
    - Array-like holder for Draft objects
    - has readonly accessor for length
    - has forEach to run callback on all contained Draft objects
- Draft object
    - standalone class to describe fields for a Draft instance
- Tests
    - Drafts: unit tests for adding, deleting, clearing, fetching by id
    - Draft.List: unit tests for length, forEach
    - Draft: unit tests for new Draft from empty object and from existing Draft
- Issues
    - Not sure if recipients should be stored as Array or String

Comment 6

[Evelyn Eastmond [:evhan55]]

Rick, I took your feedback from the PR and from IRC and pushed an updated commit @ Nov 15 11:28pm Eastern.

Comment 7

[Rick Waldron [:rwaldron]]

(In reply to Evelyn Eastmond [:evhan55] from comment #6)
> Rick, I took your feedback from the PR and from IRC and pushed an updated
> commit @ Nov 15 11:28pm Eastern.

Awesome, reviewed and a few comments. I think this is likely the last round and then I will r+

Comment 8

[Evelyn Eastmond [:evhan55]]

Comment on attachment 833097 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13756

Resubmitting for review.
It's looking clean, thanks very much for all the help, I'm happy.

Comment 9

[Rick Waldron [:rwaldron]]

Comment on attachment 833097 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/13756

r=me

Comment 10

[Evelyn Eastmond [:evhan55]]

https://github.com/mozilla-b2g/gaia/commit/3519431a4775c2e0c3567b00e572a8a4fc19730c

Landed on master by rwaldron