936645 - [Messages][Drafts] Add banner message for saved draft

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Evelyn Eastmond [:evhan55]]

Show a banner whenever a draft has been saved

Comment 1

[Rick Waldron [:rwaldron]]

Blocking the tabs for 5 seconds seems maddening.

Comment 2

[Rick Waldron [:rwaldron]]

Julien,

I met with Evelyn today and suggested that you might be able to make short work of adding another banner, since you have experience with the banners that already exist in the app. Let us know if you can work on this or not. If not, I can re-assign accordingly. Thanks!!

Comment 3

[Julien Wajsberg [:julienw]]

I think this banner will be quite different to what already exists in the app right now:
* in the thread list
* probably at the bottom
* probably sliding in/out (toaster-like)

We'll need to wait for the Visual Design here too.
I can give it a shot next week but feel free to get it back if you see nothing's happening.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

triage: not blocking on draft mesasge for 1.3. clear flag

Comment 5

[Julien Wajsberg [:julienw]]

(note: if someone w

Comment 6

[Julien Wajsberg [:julienw]]

again:

if someone want to steal from me, please do.

Comment 7

[Evelyn Eastmond [:evhan55]]

Hi Ayman,

V8 spec page 36 says:

"3. Messages inbox
01 Temporary banner displayed for 5 seconds informing the user 
that the message has been saved as a draf"

What should the banner say?

Evelyn

Comment 8

[Evelyn Eastmond [:evhan55]]

Hi Ayman,

Who should I ask to address https://bugzilla.mozilla.org/show_bug.cgi?id=936645#c3 above?
Re: visual design of this banner, placement, animation, etc.

Evelyn

Comment 9

[Julien Wajsberg [:julienw]]

Visual Design is for José.

About the banner text, can you propose something? Then you can ask for a copy proof from "tyler.altes@...".

Comment 10

[José Vittone]

Hi guys, 

In my opinion, we should be using "Status" element from Building Blocks (http://buildingfirefoxos.com/building-blocks/status.html), the same used when an app installation is completed. As it is an standarized element I don't see any new visual design needed here, right?

Please ping me if something else is necessary.

Comment 11

[Evelyn Eastmond [:evhan55]]

How about:

"Message draft saved"

?

Comment 12

[Evelyn Eastmond [:evhan55]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15612

This is pending copy review for the banner message ^^

- `index.html`
    - Added markup for banner based on [http://buildingfirefoxos.com/building-blocks/status.html](http://buildingfirefoxos.com/building-blocks/status.html)
- `thread_list_ui.js`
    - Added a draft saved duration constant for 5 seconds
    - Added a pointer to the draft saved banner markup
    - Added a draft saved function that shows the banner when called
- `thread_ui.js`
    - Calls `ThreadListUI.draftSaved` after a draft is saved
- `sms.en-US.properties`
    - Added locale string for banner => "Message draft saved"
- Tests
    - Unit
        - `thread_list_ui_test.js`
            - Check that banner is hidden, shown for 5 seconds, and hidden again during `draftSaved()`
        - `thread_ui_test.js`
            - Check that `draftSaved()` is called after draft is saved
    - Manual
        - Save a draft, look for banner
        - Replace a draft, look for banner

Comment 13

[tyler.altes]

Let's use: "Message saved as draft"


(In reply to Evelyn Eastmond [:evhan55] from comment #11)
> How about:
> 
> "Message draft saved"
> 
> ?

Comment 14

[Evelyn Eastmond [:evhan55]]

(In reply to tyler.altes from comment #13)
> Let's use: "Message saved as draft"
> 

Thanks!

Comment 15

[Rick Waldron [:rwaldron]]

Comment on attachment 8363882 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15612

Works like a charm! 

Just this: https://github.com/mozilla-b2g/gaia/pull/15612/files#r9119093 and then r=me

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 8363882 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15612

left some comments but none of them are blocking, so land like this if you want, or change some things if you think my comments are good suggestions ;)

Comment 17

[Rick Waldron [:rwaldron]]

Comment on attachment 8363882 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15612

Thanks for the follow ups! r=me

Comment 18

[Evelyn Eastmond [:evhan55]]

Landed and closing: https://github.com/mozilla-b2g/gaia/commit/78ceab954fc7bfd547507481affcaf0c2009d7a7