936647 - [Messages][Drafts] Preview drafts threads in thread list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Evelyn Eastmond [:evhan55]]

Using Victoria's specs

Comment 1

[Evelyn Eastmond [:evhan55]]

Per IRC convo, I think Adam is taking this one

Comment 2

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/rwaldron/gaia/pull/1

This patch must be tested using https://github.com/rwaldron/gaia/tree/v1.3-drafts as a base. The v1.3-drafts branch has been rebased with upstream master as of 9:30EST on Friday. The 936647 was then rebased with v1.3-drafts. 

I've intentionally made the PR to myself to allow for comments as usual.

Comment 3

[Rick Waldron [:rwaldron]]

Complete rebase as of Sunday Dec 1, 6:50 EST (both v1.3-drafts and 936647)

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

Thanks,

mostly nits and questions and suggestions, nothing big!

Comment 5

[Rick Waldron [:rwaldron]]

Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

All nits addressed and questions answered.

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

r=me

will file individual bugs for the various remaining issues

Comment 7

[Adam Hyland [:protonk]]

Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

Comments left in github or fixed in Bug 936648

Comment 8

[Rick Waldron [:rwaldron]]

v1.3-drafts https://github.com/rwaldron/gaia/commit/44156228e997369abda9bb539e20d3661d5b54be

Comment 9

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/87f4976ec3213e56dd6ec4fc98a4cc4074508916