Closed Bug 936647 Opened 11 years ago Closed 11 years ago

[Messages][Drafts] Preview drafts threads in thread list

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 6 - 12/6

People

(Reporter: evhan55, Assigned: rwaldron)

References

Details

Attachments

(1 file)

https://github.com/rwaldron/gaia/pull/1
39 bytes, text/x-github-pull-request
julienw
: review+
evhan55
: feedback+
Details | Review 
Using Victoria's specs
Assignee: nobody → evelyn
Blocks: messaging-drafts, 931095
Target Milestone: --- → 1.3 Sprint 5 - 11/22
Component: Gaia → Gaia::SMS
Target Milestone: 1.3 Sprint 5 - 11/22 → 1.3 Sprint 6 - 12/6
Per IRC convo, I think Adam is taking this one
Assignee: evelyn → achyland
Assignee: achyland → waldron.rick
This patch must be tested using https://github.com/rwaldron/gaia/tree/v1.3-drafts as a base. The v1.3-drafts branch has been rebased with upstream master as of 9:30EST on Friday. The 936647 was then rebased with v1.3-drafts. 

I've intentionally made the PR to myself to allow for comments as usual.
Attachment #8340585 - Flags: review?(felash)
Attachment #8340585 - Flags: feedback?(evelyn)
Attachment #8340585 - Flags: feedback?(achyland)
Complete rebase as of Sunday Dec 1, 6:50 EST (both v1.3-drafts and 936647)
Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

Thanks,

mostly nits and questions and suggestions, nothing big!
Attachment #8340585 - Flags: review?(felash)
Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

All nits addressed and questions answered.
Attachment #8340585 - Flags: review?(felash)
Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

r=me

will file individual bugs for the various remaining issues
Attachment #8340585 - Flags: review?(felash) → review+
Comment on attachment 8340585 [details] [review]
https://github.com/rwaldron/gaia/pull/1

Comments left in github or fixed in Bug 936648
Attachment #8340585 - Flags: feedback?(achyland)
Attachment #8340585 - Flags: feedback?(evelyn) → feedback+
https://github.com/mozilla-b2g/gaia/commit/87f4976ec3213e56dd6ec4fc98a4cc4074508916
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: