Open
Bug 936650
Opened 11 years ago
Updated 2 years ago
stretch_copybit : Unsupported Pixel format 1
Categories
(Core :: Graphics, defect)
Tracking
()
NEW
People
(Reporter: gal, Unassigned)
Details
Attachments
(1 file)
551 bytes,
patch
|
Details | Diff | Splinter Review |
This is running 1.2 on helix.
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
E/copybit ( 775): stretch_copybit : Unsupported Pixel format 1
E/msm7627a.hwcomposer( 775): drawLayerUsingCopybit: copybit stretch failed
E/HWComposer( 775): H/W Composition failed
Reporter | ||
Comment 1•11 years ago
|
||
Instead of falling back onto the GPU we actually end up not composting the frame, which is bad.
Reporter | ||
Comment 2•11 years ago
|
||
HAL_PIXEL_FORMAT_RGBA_8888 = 1,
if (ctx->mAlpha < 255) {
switch (src->format) {
// we don't support plane alpha with RGBA formats
case HAL_PIXEL_FORMAT_RGBA_8888:
case HAL_PIXEL_FORMAT_BGRA_8888:
case HAL_PIXEL_FORMAT_RGBA_5551:
case HAL_PIXEL_FORMAT_RGBA_4444:
ALOGE ("%s : Unsupported Pixel format %d", __FUNCTION__,
src->format);
return -EINVAL;
}
}
So ctx->mAlpha is < 255.
Reporter | ||
Comment 3•11 years ago
|
||
Its initialized to MDP_ALPHA_NOP, so that looks ok.
55 #define MDP_ALPHA_NOP 0xff
There are two places that set mAlphas, but both set it to 255 in the original silicon vendor source. I assume the OEM does something bad here in their drivers.
copybit->set_parameter(copybit, COPYBIT_PLANE_ALPHA, 255);
Reporter | ||
Comment 4•11 years ago
|
||
Ok, we definitely don't check for set() to fail.
Reporter | ||
Comment 5•11 years ago
|
||
Assignee: nobody → gal
Reporter | ||
Comment 6•11 years ago
|
||
That code is for JB only. That having said we shouldn't have the define there.
Reporter | ||
Comment 7•11 years ago
|
||
The silicon vendor has supplied the OEM patches for this.
https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/display/commit/?h=b2g_ics_1.2&id=4716987848deaa573b14219b0322a16b29038d29
https://www.codeaurora.org/cgit/quic/la/platform/hardware/qcom/display/commit/?h=b2g_ics_1.2&id=0c12df86df998019b35ade29e5f24e144866fc4d
I assume my blobs don't have those patches yet.
Comment 8•11 years ago
|
||
I'm assuming this is wait and see, no action on our side.
Comment 9•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: gal → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•