936670 - right-anchor is not applied while rendering text in svg

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[gr.hayduk]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131025151332

Steps to reproduce:

Display svg generated with gnuplot. The svg contains a text with text-anchor:end. See http://home.agh.edu.pl/~hayduk/ff25bug/psegs.html


Actual results:

The text is displayed at wrong position, such as text-anchor:end in svg was not applied - see the Y axis labels. They are displayed over the axis, not on the left of the axis.


Expected results:

Y axis labels in example svg chart should be displayed to the left of the axis, as they are i.e. in Chrome. They were displayed correctly in FF from June 2012.

Comment 1

[Mardeg]

This looks like a regression from bug 655877 as the labels are positioned correctly when
about:config?filter=svg.text.css-frames.enabled is set to false

Comment 2

[Robert Longson [:longsonr]]

Attachment: reduced testcase

It seems to be right adjusting the space and then putting the text after that.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch

We were getting the position assigned to the trimmed-away white space character, which doesn't have the right mPositions[].mPosition value to use for the positioning of the run.  Haven't looked for where this bug was introduced or whether it was there from the initial landing of the new text support.

Comment 4

[Cameron McCormack (:heycam)]

This bug (certain text in SVG documents could be positioned incorrectly) also probably isn't serious enough to land on Release; setting track? on current branches, though.

Comment 5

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f5bbe846139

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/6f5bbe846139

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 829729 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 839955
User impact if declined: some SVG content may display incorrectly
Testing completed (on m-c, etc.): only just landed on m-c, but automated test added
Risk to taking this patch (and alternatives if risky): low risk
String or IDL/UUID changes made by this patch: N/A

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

No need to track this, it's a regression from 21 but will take the low risk uplift to branches.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6753b1d2e902
https://hg.mozilla.org/releases/mozilla-beta/rev/37fd15101968

Comment 10

[Cameron McCormack (:heycam)]

Bug 839955 where we turned the pref on is really where the regression is, so that's Firefox 25.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/37fd15101968