Open Bug 936671 Opened 11 years ago Updated 2 years ago

ObjectActor#getPrototypeAndProperties can cause debuggee code to run

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

People

(Reporter: bbenvie, Unassigned)

References

(Blocks 1 open bug)

Details

Given the following object:

> Object.create(null, {
>   unsafe: {
>     get: (() => "I'm dangerous").bind()
>   }
> });

ObjectActor#getPrototypeAndProperties will invoke debuggee code. The heuristic that determines whether something is a safe getter relies checking for the presence of "code" on the Debugger.Object. Bound functions have no "code", but they do call into debuggee code.
This would be solved by bug 746622 which would make it possible to determine whether a given Debugger.Object is a bound function.
Depends on: 746622
Summary: ObjectActor#getPrototypeAndProperties runs debuggee code with bound getters → ObjectActor#getPrototypeAndProperties can cause debuggee code to run
Product: Firefox → DevTools
Logan, what do you think the right prioritization is here?
Flags: needinfo?(lsmyth)

My vote is P3.

Flags: needinfo?(lsmyth)
Priority: P2 → P3
Blocks: dbg-server
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.