936675 - Remove dead code for embed shells

Status: RESOLVED DUPLICATE of bug 946512

(Webmaker Graveyard :: Thimble, defect)

Description

[Kieran Sedgwick (:sedge)]

There is dead code in thimble. It should be removed, duh!

Comment 1

[Kieran Sedgwick (:sedge)]

Attachment: first swing: https://github.com/mozilla/popcorn.webmaker.org/pull/305/files

By :mjschranz

Comment 2

[Kieran Sedgwick (:sedge)]

Comment on attachment 829550 [details]
first swing: https://github.com/mozilla/popcorn.webmaker.org/pull/305/files

>https://github.com/mozilla/popcorn.webmaker.org/pull/305/files

Comment 3

[Kieran Sedgwick (:sedge)]

This isn't something I can take on right now. I'm open to discussing my priorities, but I'm busy with other things in the meantime.

Comment 4

[Pomax]

This can only really be done if make-valet is made to work localhost as well. Without a local make-valet, which takes care of the embed shells on S3, publishing with the "dead" embed code removed will actually break thimble.

One possible solution is to check whether there is a make-valet available, but this still leaves the issue of "dead in staging/production code" that people might try to fix, without realising they're not fixing what's wrong on staging/production.

Comment 5

[Jon Buckley [:jbuck]]

There are two bugs that cover this for each app:

Popcorn - https://bugzilla.mozilla.org/show_bug.cgi?id=907813
Thimble - https://bugzilla.mozilla.org/show_bug.cgi?id=946512

Marking as a dupe for this reason.