Closed
Bug 936698
Opened 11 years ago
Closed 11 years ago
The testIntTypesABI header list is woefully out of date
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: mccr8, Assigned: mccr8)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.09 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
I don't entirely know what this is supposed to do, but the test is missing a lot of things from EXPORTS.js. This puts them in sync. The test builds locally.
Attachment #829606 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 829606 [details] [diff] [review] update the list Review of attachment 829606 [details] [diff] [review]: ----------------------------------------------------------------- At this point we could also probably just remove the test. I don't think there's much danger of us slouching back into the non-<stdint.h> types these days.
Attachment #829606 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab19630963cc
|
|
Assignee | |
Comment 4•11 years ago
|
||
L64 debug try run was green: https://tbpl.mozilla.org/?tree=Try&rev=8ab149fedc09
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ab19630963cc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•