Closed Bug 936721 Opened 11 years ago Closed 11 years ago

Linux PGO permaorange TEST-UNEXPECTED-FAIL | AsyncPanZoomController.Overzoom | Value of: 0 | AsyncPanZoomController.Overzoom | test completed (time: 0ms) | GTest unit test: failed

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: kats)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Part 1 - Fuzzy equals
1.40 KB, patch
botond
: review+
Details | Diff | Splinter Review
Part 2 - Minor cleanup
6.59 KB, patch
botond
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=30350951&tree=Mozilla-Inbound#error2
slave: bld-linux64-ec2-012



TEST-PASS | AsyncPanZoomController.Constructor | test completed (time: 0ms)
TEST-START | AsyncPanZoomController.Pinch
TEST-PASS | AsyncPanZoomController.Pinch | test completed (time: 0ms)
TEST-START | AsyncPanZoomController.Overzoom
TEST-UNEXPECTED-FAIL | AsyncPanZoomController.Overzoom | Value of: 0
Expected: fm.mScrollOffset.x
Which is: -2.23518e-08 @ /builds/slave/m-in-lx-pgo-000000000000000000/build/gfx/tests/gtest/TestAsyncPanZoomController.cpp:225
TEST-UNEXPECTED-FAIL | AsyncPanZoomController.Overzoom | Value of: 0
Expected: fm.mScrollOffset.y
Which is: -2.23518e-08 @ /builds/slave/m-in-lx-pgo-000000000000000000/build/gfx/tests/gtest/TestAsyncPanZoomController.cpp:226
TEST-UNEXPECTED-FAIL | AsyncPanZoomController.Overzoom | test completed (time: 0ms)
TEST-START | AsyncPanZoomController.SimpleTransform
TEST-PASS | AsyncPanZoomController.SimpleTransform | test completed (time: 0ms)
TEST-START | AsyncPanZoomController.ComplexTransform
TEST-PASS | AsyncPanZoomController.ComplexTransform | test completed (time: 1ms)
TEST-START | AsyncPanZoomController.Pan
TEST-PASS | AsyncPanZoomController.Pan | test completed (time: 0ms)
TEST-START | AsyncPanZoomController.Fling
TEST-PASS | AsyncPanZoomController.Fling | test completed (time: 0ms)
TEST-START | AsyncPanZoomController.OverScrollPanning
TEST-PASS | AsyncPanZoomController.OverScrollPanning | test completed (time: 0ms)
TEST-START | APZCTreeManager.HitTesting1
TEST-PASS | APZCTreeManager.HitTesting1 | test completed (time: 0ms)
TEST-START | APZCTreeManager.HitTesting2
TEST-PASS | APZCTreeManager.HitTesting2 | test completed (time: 0ms)
TEST-START | MozillaGTestSanity.Runs
TEST-PASS | MozillaGTestSanity.Runs | test completed (time: 0ms)
TEST-START | MozillaGMockSanity.Runs
TEST-PASS | MozillaGMockSanity.Runs | test completed (time: 0ms)
TEST-UNEXPECTED-FAIL | GTest unit test: failed
Finished running AsyncPanZoomController tests.
make[1]: *** [check] Error 1
make[1]: Leaving directory `/builds/slave/m-in-lx-pgo-000000000000000000/build/obj-firefox/testing/gtest'
make: *** [check] Error 2
make -C js/src check
make[1]: Entering directory `/builds/slave/m-in-lx-pgo-000000000000000000/build/obj-firefox/js/src'
I'll look into these. These tests should be 100% deterministic so I don't see why they could possibly fail intermittently.
Assignee: nobody → bugmail.mozilla
Since his seems to only happen on PGO builds, presumably some black magic of compiler optimizations is screwing with our code and introducing rounding error. Deal with it.
Attachment #829742 - Flags: review?(botond)
Piggybacking this cleanup patch onto this bug. Unrelated really but I'm too lazy to file a new one.
Attachment #829743 - Flags: review?(botond)
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> I'll look into these. These tests should be 100% deterministic so I don't
> see why they could possibly fail intermittently.

Indeed, they are failing 100% of the time in Linux PGO builds.
Summary: Intermittent TEST-UNEXPECTED-FAIL | AsyncPanZoomController.Overzoom | Value of: 0 | AsyncPanZoomController.Overzoom | test completed (time: 0ms) | GTest unit test: failed → Linux PGO permaorange TEST-UNEXPECTED-FAIL | AsyncPanZoomController.Overzoom | Value of: 0 | AsyncPanZoomController.Overzoom | test completed (time: 0ms) | GTest unit test: failed
Attachment #829742 - Flags: review?(botond) → review+
Attachment #829743 - Flags: review?(botond) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1644982806a
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2a307e03692

Is there a way to run PGO builds on try? trychooser doesn't seem to have it and I don't believe it runs by default. It might be interesting to track down exactly which operation is introducing the rounding error. I think the test runs little enough code that it should be doable.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #22)
> Is there a way to run PGO builds on try? trychooser doesn't seem to have it
> and I don't believe it runs by default.

See https://wiki.mozilla.org/ReleaseEngineering/TryChooser#What_if_I_want_PGO_for_my_build
https://hg.mozilla.org/mozilla-central/rev/d1644982806a
https://hg.mozilla.org/mozilla-central/rev/d2a307e03692
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: