Closed Bug 936722 Opened 11 years ago Closed 11 years ago

Scriptloader is safe and should not generate a warning

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: 4mr.minj, Unassigned)

Details

My add-on triggers multiple warnings that say:
|Illegal or deprecated access to the `scriptloader` global|

https://groups.google.com/d/msg/mozilla.dev.extensions/TMFWetkVEDQ/fbrHUI3CrWgJ
Status: UNCONFIRMED → NEW
Ever confirmed: true
This was added as part of bug 653155:

https://github.com/mozilla/amo-validator/commit/893e6488c52e558ead98b010b7a863483c557f84

Jorge: should it be removed?
Flags: needinfo?(jorge)
I don't quite get what that bug is about. I'll let Kris figure out if we still need it.
Flags: needinfo?(jorge) → needinfo?(kmaglione+bmo)
It wasn't added as part of that bug. That just made the tests more reliable.

It was added to the Remora validator back when the subscript loader was capable of loading remote scripts, which is no longer the case. It can still be used to load arbitrary file: URLs, so it might be worth keeping, but in general it probably just generates more noise than it's worth.
Flags: needinfo?(kmaglione+bmo)
Let's remove it then.
https://github.com/mozilla/amo-validator/commit/78237d6dbbaf795c2cf350a6d63897e5f221bd62
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.