936763 - B2G MMS: the connected/disconnected network can come from 3G not MMS, which throws exceptions when accessing MMS proxy settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Gene Lian (I already quit Mozilla)]

Steps:

1. Turn off 3G.
2. Send an MMS.
3. MmsService.js will create a connection for that and cache it for 30 seconds.
4. Within this 30 seconds, turn on 3G.
5. Log shows:

E/GeckoConsole(  111): [JavaScript Error: "NS_ERROR_UNEXPECTED: 'Unexpected error' when calling method: [nsIRilNetworkInterface::mmsc]" {file: "jar:file:///system/b2g/omni.ja!/components/MmsService.js" line: 165}]

Comment 2

[Gene Lian (I already quit Mozilla)]

I don't have a better solution by far since APN can be shared for 3G and MMS, unless we can expose something like .inConnectedTypes(...).

Comment 3

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 4

[Gene Lian (I already quit Mozilla)]

Bug 928861 can help this a lot, which provides a callback not observer for connected. This patch is just a work-around.

Comment 5

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2

A better solution. Please see the comment. Thanks!

Comment 6

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V2.1

Polish the comment.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6d7dd3e97d68

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d7dd3e97d68

Comment 9

[Gene Lian (I already quit Mozilla)]

Hi skao, please take a look at this bug which might be related to what you're working for NetworkManager.acquireConnection(). Well, if it's lucky enough it might also solve bug 937013.

Btw, thanks Vicamo for the review and check-in. :)

Comment 10

[Shao Hang Kao [:skao]]

Hi Gene,

I tried a build including this patch and didn't solve bug 937013 :(