936789 - Faster CC logger

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: faster_cc_log.diff

This makes the logger a lot faster, so I can just process all the data in browser.
(nsTArray ended up doing memcpy all the time)

Comment 1

[Andrew McCreight [:mccr8]]

Comment on attachment 829739 [details] [diff] [review]
faster_cc_log.diff

Review of attachment 829739 [details] [diff] [review]:
-----------------------------------------------------------------

It would be handy to have a segmented array data structure in Gecko.

Hopefully this won't increase memory usage too much on mobile.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yeah, we need some kind of nsTBigArray, which doesn't promise continues memory location for indexes.

Do we run CC logger on mobile, I mean the API which is used in JS.
The patch doesn't affect to creating CC graph files.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

On desktop CCGraph describers don't take too much memory comparing to the JS stuff needed to
actually analyze the graph.

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #2)
> Do we run CC logger on mobile, I mean the API which is used in JS.
> The patch doesn't affect to creating CC graph files.

Ah, right!  Yeah, we just use the file dumping for B2G.  So, we should be okay.

> Yeah, we need some kind of nsTBigArray, which doesn't promise continues memory location for indexes.

I've long considered generalizing the EdgePool data structure, but I've been too lazy to actually do it.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v3, remove unused mNextIndex

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/147cfc5ab3b6

Comment 8

[Josh Matthews [:jdm]]

nsSegmentedBuffer exists, and might be what you're looking for.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/147cfc5ab3b6