936864 - Gaia keyboard doesn't trigger async animation

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

STR:
1) Click on 'I'm thinking off...' field on the b2g homescreen
2) Hide the keyboard

Notice the animation is very janky. This animation looks to be properly designed to hit async animations and the keyboard is layerized during the animation as well.

CSS property:
http://mxr.mozilla.org/gaia/source/apps/system/style/system/keyboard.css#25

Comment 1

[Benoit Girard (:BenWa)]

Any ideas dzbarsky why async animations aren't hit here?

Comment 2

[David Zbarsky (:dzbarsky)]

I don't have a working B2G build at the moment.  Does enabling animation logging show anything interesting in logcat?

Comment 3

[Benoit Girard (:BenWa)]

No, nsLayoutUtils::IsAnimationLoggingEnabled isn't even checked.

Comment 4

[Benoit Girard (:BenWa)]

Thanks dzbarsky. I found the problem.

Looks like it was a regression from bug 929362 after all.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: patch - logic error

Comment 6

[Markus Stange [:mstange]]

Ugh.

Comment 7

[Benoit Girard (:BenWa)]

Comment on attachment 831772 [details] [diff] [review]
patch - logic error

Ohh you're still up :). Feel free to steal the review. This is quite trivial really.

Comment 8

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/b2g-inbound/rev/00c3e5302d24

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00c3e5302d24

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/8151f46ae991

Is this B2G-only? If so, I assume we don't care about uplifting this to Aurora/Beta and the status for those release can be wontfix.

Comment 11

[Benoit Girard (:BenWa)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #10)
> https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/8151f46ae991
> 
> Is this B2G-only? If so, I assume we don't care about uplifting this to
> Aurora/Beta and the status for those release can be wontfix.

IMO I would rather see this make it to aurora as well just to keep things simple. This is something users can turn on for testing.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

I assume "this" is OMTA? In that case, please request approval. Also note that b2g26 != beta, so Firefox 26 is still affected.

Comment 13

[Benoit Girard (:BenWa)]

Comment on attachment 831772 [details] [diff] [review]
patch - logic error

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 929362
User impact if declined: none, unless users have preference flipped for testing.
Testing completed (on m-c, etc.): on m-c. Simple logic change fix up
Risk to taking this patch (and alternatives if risky): none, this is preffed off
String or IDL/UUID changes made by this patch:none

bug 929362 uplifted a regression and I'd like to uplift the fix everywhere the regression went in. This is used by OMTAnimation which is only enabled by default on b2g and I'd like to avoid dealing with a matrix of trees where this is or isn't fixed.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

This isn't user impacting enough for tracking and it's preffed off, but we'll take the low risk patches for uplift.

Comment 15

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eabe00ce2f40
https://hg.mozilla.org/releases/mozilla-beta/rev/f51e97cf27aa

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/f51e97cf27aa