Closed Bug 936890 Opened 6 years ago Closed 6 years ago

[ru] Update icon for Wikipedia searchplugin

Categories

(Mozilla Localizations :: ru / Russian, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: unghost, Assigned: unghost)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch wiki.diff (obsolete) — Splinter Review
I've noticed that icons in Russian Wikipedia searchplugins is outdated compared to en-US, so I want to update them. Looks like they are not locale specific.
Attachment #829848 - Flags: review?(francesco.lodolo)
Comment on attachment 829848 [details] [diff] [review]
wiki.diff

Review of attachment 829848 [details] [diff] [review]:
-----------------------------------------------------------------

I'll need to think a bit about this, since I need to understand how to deal with the new wikipediametrofx searchplugin (basically I'd be reviewing a patch to a searchplugin that shouldn't exist yet).

In the meantime, if you want I'll be glad to review a patch to fix only the wikipedia-ru.xml file
I'd suggest to use the same icon en-US is using
http://hg.mozilla.org/mozilla-central/file/16949049f03d/browser/locales/en-US/searchplugins/wikipedia.xml
Attachment #829848 - Flags: review?(francesco.lodolo)
Attached patch Patch v.2Splinter Review
Assignee: nobody → unghost
Attachment #829848 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #830049 - Flags: review?(francesco.lodolo)
Summary: [ru] Update icons for Wikipedia searchplugins → [ru] Update icons for Wikipedia searchplugin
Summary: [ru] Update icons for Wikipedia searchplugin → [ru] Update icon for Wikipedia searchplugin
Out of curiosity I confronted this new icon (copied from en-US), the old icon and the icon currently used as favicon on Wikipedia.

Can you spot any difference between 1) and 2)? Because I honestly can't. 
At this point it makes probably more sense to go directly with 3). Alexander, what do you think?
(In reply to Francesco Lodolo [:flod] from comment #3)
> Created attachment 830056 [details]
> Icon comparison (old, new, current wikipedia)
> 
> Out of curiosity I confronted this new icon (copied from en-US), the old
> icon and the icon currently used as favicon on Wikipedia.
> 
> Can you spot any difference between 1) and 2)? Because I honestly can't. 
> At this point it makes probably more sense to go directly with 3).
> Alexander, what do you think?

Have you made this comparison on Mac in HiDPI mode? Cause new en-US icon has been introduced for use in HiDPI mode, see Bug 795495
I don't see any difference between 1) and 2) but I'm on Linux.
(In reply to Alexander L. Slovesnik from comment #4)
> Have you made this comparison on Mac in HiDPI mode? Cause new en-US icon has
> been introduced for use in HiDPI mode, see Bug 795495

Nope, I don't have a Retina mac, only standard screens. I'll investigate with Axel about the new icon.
Frank, do you have advice here considering you're the last person who touched Wikipedia's icon?
Flags: needinfo?(fryn)
I recommend using the same icon file as en-US does.
Flags: needinfo?(fryn)
Comment on attachment 830049 [details] [diff] [review]
Patch v.2

Review of attachment 830049 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Frank. 

The current patch is good then, please land with reference to this bug and review (r=flod).
Attachment #830049 - Flags: review?(francesco.lodolo) → review+
You need to log in before you can comment on or make changes to this bug.