Update html5lib-tests to latest version as of Oct 8, 2013

RESOLVED FIXED in mozilla28

Status

()

Core
HTML: Parser
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wchen, Assigned: wchen)

Tracking

unspecified
mozilla28
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The version of the html5lib-tests in the tree are pretty old and are missing important tests for the template element.
(Assignee)

Comment 1

4 years ago
Created attachment 830016 [details] [diff] [review]
Import downstream of html5lib-tests as of Oct 8, 2013.

Things that happened in this patch:
- Replaced the test files with the latest version from upstream.
- Fixed minor javascript error in parser_web_testrunner.js
- Updated parser_datareader.js to be able to handle template contents.
Attachment #830016 - Flags: review?(hsivonen)
(Assignee)

Comment 2

4 years ago
I forgot to mention that there were two new tests that we currently don't pass. In particular:

<!DOCTYPE html><body><command>A

I'm not sure what we want to do about it because <command> is deprecated. It's not mentioned in the spec anymore.

<template><template><table>Foo

This is a problem that I fix in Bug 937003.

For now I have simply added these two tests cases to the exception file.
Attachment #830016 - Flags: review?(hsivonen) → review+
Comment on attachment 830016 [details] [diff] [review]
Import downstream of html5lib-tests as of Oct 8, 2013.

Review of attachment 830016 [details] [diff] [review]:
-----------------------------------------------------------------

::: parser/htmlparser/tests/mochitest/html5_tree_construction_exceptions.js
@@ +8,5 @@
>    "<!doctype html><keygen><frameset>" : true, // Bug 101019
>    "<select><keygen>" : true, // Bug 101019
>    "<!DOCTYPE html><body><keygen>A" : true, // Bug 101019
> +  "<!DOCTYPE html><body><command>A" : true,
> +  "<template><template><table>Foo" : true,

Mark these with bugs, please
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f62c40b75f22
Flags: in-testsuite+
Summary: Import downstream of html5lib-tests as of Oct 8, 2013 → Update html5lib-tests to latest version as of Oct 8, 2013
https://hg.mozilla.org/mozilla-central/rev/f62c40b75f22
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.