Closed Bug 937002 Opened 9 years ago Closed 9 years ago

[DSDS][Gaia] Make SimPinDIalog support 2 simcards

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: eragonj, Assigned: eragonj)

References

Details

Attachments

(1 file)

We have to make sure SimPinDialog can work on DSDS structure.
Concept : 

Because right now we have to new instance for SimPinDialog, maybe we can add additional options for it to make it more complex for different situations.
This patch will use latest DSDS related API to set specific simcard.
Comment on attachment 830045 [details] [review]
WIP

Hi Arthur,

I left a option parameter for it to make developers customize it for later use.
 
Not sure this is ok or not ? Any idea, Arthur :D ?
Attachment #830045 - Flags: feedback?(arthur.chen)
Comment on attachment 830045 [details] [review]
WIP

Good work! Per our discussion, please ensure the card slot is valid before calling to SimPinDialog. f=me.
Attachment #830045 - Flags: feedback?(arthur.chen) → feedback+
(In reply to Arthur Chen [:arthurcc] from comment #5)
> Comment on attachment 830045 [details] [review]
> WIP
> 
> Good work! Per our discussion, please ensure the card slot is valid before
> calling to SimPinDialog. f=me.

Thanks Arthur, 

I will update old code using SimPinDialog to use newest API and add some error handling.

:D
This bug is invalid because related patches are included in bug 928295.

Thanks all.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.