937002 - [DSDS][Gaia] Make SimPinDIalog support 2 simcards

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

We have to make sure SimPinDialog can work on DSDS structure.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Concept : 

Because right now we have to new instance for SimPinDialog, maybe we can add additional options for it to make it more complex for different situations.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: WIP

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

This patch will use latest DSDS related API to set specific simcard.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 830045 [details] [review]
WIP

Hi Arthur,

I left a option parameter for it to make developers customize it for later use.
 
Not sure this is ok or not ? Any idea, Arthur :D ?

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 830045 [details] [review]
WIP

Good work! Per our discussion, please ensure the card slot is valid before calling to SimPinDialog. f=me.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #5)
> Comment on attachment 830045 [details] [review]
> WIP
> 
> Good work! Per our discussion, please ensure the card slot is valid before
> calling to SimPinDialog. f=me.

Thanks Arthur, 

I will update old code using SimPinDialog to use newest API and add some error handling.

:D

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

This bug is invalid because related patches are included in bug 928295.

Thanks all.