Closed Bug 937040 Opened 11 years ago Closed 11 years ago

Revise contacts app to adapt to WebIDL changes in a uniform way

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 5 - 11/22

People

(Reporter: jmcf, Assigned: gtorodelvalle)

Details

Attachments

(2 files)

13663.html
384 bytes, text/html
jmcf
: review+
Details
13712.html
384 bytes, text/html
Details 
We need to revise fb_contact.js and fb_utils.js trying to find places where there could be regressions due to new mozContact WebIDL changes.
blocking-b2g: --- → 1.3?
Assignee: jmcf → gtorodelvalle
Attached file 13663.html — 

        Attachment #831539 -
        Flags: review?(jmcf)

    
  
Summary: Revise  fb_contact.js and fb_utils.js to adapt to WebIDL changes → Revise  contacts app to adapt to WebIDL changes in a uniform way

    
  

        Attachment #831539 -
        Flags: review?(jmcf) → review+

    
  
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 Sprint 5 - 11/22

    
    

    
  
reverted as 4ea5adac92d6a9ab035e708e941d50be0d670da2 for lint errors.
Sorry Jose :-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        13712.html
        — 
      

    


  
Thanks Julien for noticing it! ;-)

        Attachment #832329 -
        Flags: review?(felash)

    
    

    
  
Comment on attachment 832329 [details]
13712.html

No need to review, just land when travis is green :)

        Attachment #832329 -
        Flags: review?(felash)

    
    

    
  
Merged in master: https://github.com/mozilla-b2g/gaia/commit/15557524884398ec1679e49d2498f52ab3655016
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED

    
    

    
  
already in master. clear flag
blocking-b2g: 1.3? → ---

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: