CSS ".quick-links a" shouldn't be "display: block"

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alberts, Unassigned)

Tracking

Details

(Whiteboard: [specification][type:change])

(Reporter)

Description

5 years ago
What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
The links in the side bar (which I find great btw) should be left as inline or set to inline-block elements if required. It is irritating if you have e.g. a link with just two characters like "mm", but can trigger it by clicking on the whitespace far to it's right.

https://developer.mozilla.org/en-US/docs/Web/CSS/border-top-left-radius

What problems would this solve?
===============================
Click on the whitespace right to a link to focus the page and get transferred to a new page instead.

Who would use this?
===================
Everyone using the side bar

What would users see?
=====================
hover, when hovering the link, but not the space next to it

What would users do? What would happen as a result?
===================================================
User would not accidentally trigger a link in the sidebar 

Is there anything else we should know?
======================================
Blocks: 910513
I think Holly's feedback here is needed. My first test would make me think this is a real bug, but I'm not sure if it wasn't on purpose or not, and if so why.
Flags: needinfo?(hhabstritt.bugzilla)

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/bcc6c2fe87a155e81d5b99a78dad4e498ead8cb4
Fix bug 937065 - Update link display type

https://github.com/mozilla/kuma/commit/9b9b6d68ac0461ed12f9726ad6f5b62769bbfe37
Merge pull request #1636 from darkwing/ql-display-937065

Fix bug 937065 - Update link display type

Updated

5 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This wasn't a conscious choice as far as I know. The use case he brings up is a good point and I think we should isolate the link to the words only instead of display:block.
Flags: needinfo?(hhabstritt.bugzilla)
You need to log in before you can comment on or make changes to this bug.