Closed
Bug 937068
Opened 11 years ago
Closed 11 years ago
Enhance wait in test_contact_add_photo
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: moz.teodosia)
Details
Attachments
(3 files)
As you can see from the screenshot the Contacts app is still in 'loading' mode while the test is completed. The waits in this test need to be strengthened. Then the test should pass.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → moz.teodosia
Assignee | ||
Comment 1•11 years ago
|
||
The test is failing for me with issue in bug 934537 after I run the test more than once. I updated the xfail bug and added a wait.
Assignee | ||
Comment 2•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #830158 -
Flags: review?(zcampbell)
Attachment #830158 -
Flags: review?(trifandreialin)
Attachment #830158 -
Flags: review?(florin.strugariu)
Attachment #830158 -
Flags: review?(andrei.hutusoru)
Comment 3•11 years ago
|
||
Comment on attachment 830158 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13576 looks ok but we should rename the bug and get out the un-xfail
Attachment #830158 -
Flags: review?(florin.strugariu) → review+
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 830158 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13576 r+ too, I will merge
Attachment #830158 -
Flags: review?(zcampbell) → review+
Reporter | ||
Updated•11 years ago
|
Summary: Unxfail and enhance wait in test_contact_add_photo → Enhance wait in test_contact_add_photo
Reporter | ||
Comment 5•11 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/9748748c3303b270274b880052395245ab1b6c82 Let's cherry-pick the enhanced wait snippet for v1.2 but leave the xfail code behind.
status-b2g-v1.2:
--- → affected
Assignee | ||
Comment 6•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #830845 -
Attachment description: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13624 → [v1.2]Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13624
Attachment #830845 -
Flags: review?(zcampbell)
Attachment #830845 -
Flags: review?(florin.strugariu)
Attachment #830845 -
Flags: review?(andrei.hutusoru)
Assignee | ||
Updated•11 years ago
|
Attachment #830158 -
Flags: review?(trifandreialin)
Attachment #830158 -
Flags: review?(andrei.hutusoru)
Assignee | ||
Comment 7•11 years ago
|
||
The v1.2 branch is not affected by bug 934537. I ran the test several times and it passes.
Reporter | ||
Updated•11 years ago
|
Attachment #830845 -
Flags: review?(zcampbell)
Assignee | ||
Updated•11 years ago
|
Attachment #830845 -
Flags: review?(trifandreialin)
Attachment #830845 -
Flags: review?(bob.silverberg)
Comment 8•11 years ago
|
||
Landed in v1.2: https://github.com/mozilla-b2g/gaia/commit/b29292e92f32b5a0ab14ea3346eae02d94cd2cd4
Updated•11 years ago
|
Attachment #830845 -
Flags: review?(trifandreialin)
Attachment #830845 -
Flags: review?(florin.strugariu)
Attachment #830845 -
Flags: review?(bob.silverberg)
Attachment #830845 -
Flags: review?(andrei.hutusoru)
Attachment #830845 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•