937091 - [B2G][Helix][Audio][tianhuajian]The device has no dial sound after has pressed 50 numbers

Status: RESOLVED DUPLICATE of bug 917630

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E)

Steps to reproduce:

A is FFOS phone  
1. A press the dial number in dial app
2. Press the dial number more than 50 times



Actual results:

2. The device has no dial sound after have dialed 50 times


Expected results:

2. The device should still have dial sound after have dialed 50 times

【Test Count*】：5
【Found Count*】：5
【Gaia commit ID*】: V1.1HD
【Gecko commit ID*】:  1.1.0 HD
【Log*】：
【Network environment】：
【Resume operation】：

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Hi lecky! Thank you very much for your input ;)

There is a limit of 50 digits regarding the maximum number of keys typed in the Dialer main page (see https://github.com/mozilla-b2g/gaia/blob/master/shared/js/dialer/keypad.js#L20). Anyhow, it is true that in my opinion some kind of feedback should be provided to the user since right now nothing happens if additional digits are typed and it is kind of weird from a user perspective.

So I am need-info Carrie so she can suggest us the path to follow here ;) Thanks!

Comment 2

[Carrie Wang [New account: [e-mail]]]

Hi, 


I'd like to know, why should we have this 50 numbers limitation? Thanks!

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

It seems that code was included in the patch for bug 1037066 and since Doug was involved in it, I am need-infoing him just in case he recalls the reason for this 50 numbers limitation ;) Thanks!

Comment 4

[Doug Sherk (:drs) (inactive)]

Based on history from bug 872921, the Dialer can only dial up to 50 digits.
We lifted the 50-digit restriction for connected calls in bug 917630.

I think we should resolve this as it's by design. It's likely that this bug was filed before bug 917630 was fixed, so it was reporting the 50-digit issue for connected calls.