Improve string concat on Array.prototype.join

RESOLVED INVALID

Status

()

RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: sankha, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We can use ValueToStringBuffer which will be cheaper that using .toString() in ArrayJoinKernel.
(Reporter)

Comment 1

5 years ago
Created attachment 830153 [details] [diff] [review]
patch v1
Attachment #830153 - Flags: review?(luke)
I don't really see why. ValueToStringBuffer seems to do about the same: http://dxr.mozilla.org/mozilla-central/source/js/src/vm/StringBuffer.h?from=ValueToStringBuffer#l137
(Reporter)

Updated

5 years ago
Attachment #830153 - Flags: review?(luke)
(Reporter)

Comment 3

5 years ago
Sorry, it was due to some bad testing on my system. Sorry for the noise.
Assignee: sankha93 → nobody
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.