937116 - [Download Manager] Create a utility library for common DOM Download operations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We have realised that we are doing some operations one and again in different part of the code with the DOM Download objects.

Some of those operations will be reused across the notifications and the download list.

There we should be able to:

- Get the file name from the URL.
- Deal with time operations.
- Deal with size operations.
- Deal with percentage of the download.

Comment 1

[Cristian Rodriguez (:crdlc)]

Icons will be shared between the download list and notifications

* getIcon()

Titles like 'download failed', 'download completed', bla bla could be shared between both of them as well, are you agree?

* getTitle() ???

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 3

[Borja Salguero [:borjasalguero]]

This library is based on the structure defined https://etherpad.mozilla.org/vYG4E1G6HE

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 830893 [details] [review]
Pull request

It looks good although please review some comment on Github. After addressing them, please ask again for a new review. Thanks a lot mate! Good job

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 830893 [details] [review]
Pull request

For me, it  is r+ right now, thanks for your great work!

Comment 6

[Borja Salguero [:borjasalguero]]

Hi Kaze! This patch is only adding tests to Settings, because there we will have the 'Downloads' panel. We need to land this asap for moving forward with following patches, could you take a look? It would be awesome if we can land this today! THanks!! Gracias! :)

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 830893 [details] [review]
Pull request

LGTM

Comment 8

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/61ac5d3bc764e66dd35eb1d43b74282b1b0232c2
https://github.com/borjasalguero/gaia/commit/f9a10c84616cbab4a80e3850a405564db26baacd

Merged!! Thanks all!