937164 - Add "do not touch l10n changesets" option to Ship-it

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect, P3)

Description

[Rail Aliiev [:rail]]

It would be very useful for ESR releases.

Comment 1

[[e-mail] (:bhearsum)]

This would mean making the l10n changesets <textarea> an optional field. This might make things more complicated for downstream consumers. Whatever we do here, we need to be careful to make sure it works clearly for all situations.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

if <textarea> is empty, pop up confirming "did you mean to re-use the existing l10n csets?", then re-use or grab what the user inputs.

Comment 3

[Aki Sasaki (not active)]

I think we can make the the textarea required unless the checkbox is checked (and then grey it out in that case).

Comment 4

[[e-mail] (:bhearsum)]

(In reply to [e-mail] [:lsblakk] from comment #2)
> if <textarea> is empty, pop up confirming "did you mean to re-use the
> existing l10n csets?", then re-use or grab what the user inputs.

"existing l10n changesets" isn't really a known thing. Ship It makes some intelligent guesses about what your previous release may be in making suggestions for versions/partials, but I don't think that's something we should trust like this. Perhaps we could do something like "re-use changesets from version X.Y.Z" - which would put the decision on the user.

Comment 5

[[e-mail] (:bhearsum)]

Clearly this isn't a high priority - hasn't been touched in months.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

This would be a nice addition from relman's perspective as it removes a potential source of copy/paste errors. I like the idea from comment 4 about reusing changesets from version X.Y.Z. Ship-it should be smart enough to suggest what X.Y.Z is but this should be configurable by the user. For a v1 of this feature, we can have ship-it suggest and then override via the existing copy/paste mechanism if ship-it is wrong.

Comment 7

[[e-mail] (:bhearsum)]

Mass component change for ship it bugs.

Comment 8

[Rail Aliiev [:rail]]

It's all automatic now! jlorenzo++