[Cost Control] Remove proxy

RESOLVED FIXED in Firefox OS v1.3T

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: salva, Assigned: mai)

Tracking

unspecified
1.3 C1/1.4 S1(20dec)
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed)

Details

Attachments

(1 attachment)

Once, all the dependent functionality is added, there will be no use of former API so the proxy can could be removed.
Depends on: 937041
Removing 1.3? since it won't be a blocker but nice to have for v1.3
blocking-b2g: 1.3? → ---
Duplicate of this bug: 927615
(Assignee)

Updated

5 years ago
QA Contact: mri
(Assignee)

Updated

5 years ago
Assignee: nobody → mri
QA Contact: mri
(Assignee)

Comment 3

5 years ago
Created attachment 8345736 [details]
patch v1.0

Please, could you review the code?
Regards
Attachment #8345736 - Flags: review?(salva)

Updated

5 years ago
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Comment on attachment 8345736 [details]
patch v1.0

Working nice. Thank you :mai!
Attachment #8345736 - Flags: review?(salva) → review+
(Assignee)

Comment 5

5 years ago
Master: eb7d58df7692b57bd471353755679b23441a90fb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Hi,

Bug 858017 is blocked by this bug since proxy is not supporting alarms (this support is implemented within Bug 858017).
Blocks: 858017
Whiteboard: [tarako]
triage: 1.3T+ to get into Tarako branch
blocking-b2g: --- → 1.3T+
Whiteboard: [tarako]
status-b2g-v1.3T: --- → ?

Updated

5 years ago
status-b2g-v1.3T: ? → affected

Updated

5 years ago
status-b2g-v1.4: --- → fixed
Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks
Flags: needinfo?(ying.xu)

Comment 9

5 years ago
(In reply to Joe Cheng [:jcheng] from comment #8)
> Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you
> completed the uplift, can you please set status-b2g-v1.3T to fixed? please
> let us know if you have problems with it. thanks

Hi,Joe
  Is there any way to verify this bug after merge it to 1.3t branch?

Updated

5 years ago
Flags: needinfo?(jcheng)

Comment 10

5 years ago
hi,marina
 I met some error when trigger the travis-ci after pulling request .please see:
https://travis-ci.org/mozilla-b2g/gaia/builds/20657822

I'd like to konw whether these errors should be resolved or just ignore them?Thank you!
Flags: needinfo?(mri)
(Assignee)

Comment 11

5 years ago
Hi, 
The fails reported by the travis are not related with this patch. I thought travis is not working well.

* The test-agent job sends the following error: 
    No permission to use the keyboard API for http://system.gaiamobile.org:8080
    ✖ 1 of 6799 tests failed:
* The marionette job fails becauose of a contact test:
    70 passing (9m)
    16 pending
    1 failing

       1) Contacts > Details Merging 15 contacts: TypeError: Cannot read property '1' of null at Object.Contacts.l10n (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/marionette/lib/contacts.js:107:33)


IMHO, you must ignore the errors.
Regards.
Flags: needinfo?(mri)

Comment 12

5 years ago
(In reply to marina rodríguez [:mai] from comment #11)
> Hi, 
> The fails reported by the travis are not related with this patch. I thought
> travis is not working well.
> 
> * The test-agent job sends the following error: 
>     No permission to use the keyboard API for
> http://system.gaiamobile.org:8080
>     ✖ 1 of 6799 tests failed:
> * The marionette job fails becauose of a contact test:
>     70 passing (9m)
>     16 pending
>     1 failing
> 
>        1) Contacts > Details Merging 15 contacts: TypeError: Cannot read
> property '1' of null at Object.Contacts.l10n
> (/home/travis/build/mozilla-b2g/gaia/apps/communications/contacts/test/
> marionette/lib/contacts.js:107:33)
> 
> 
> IMHO, you must ignore the errors.
> Regards.

Thank you for your answer!And I'd like to know is there any way to verify this bug after merge this patch?
(Assignee)

Comment 13

5 years ago
The best way to test if all is correct is launched the costcontrol application, and check that you have traffic data info. This proxy was needed for the transition between version 1.0 to 2.0 of the Networkstats API, to deal with a problem when the app recovers the data samples by interface.

This proxy is not longer needed, besides only has implemented the methods to recover info, not to manage alrmas. For these reasons, we have to eliminate.

Regards

Comment 14

5 years ago
https://github.com/mozilla-b2g/gaia/pull/17144/files

commitid:1248de807da29bc5c3ebc8e25f9042c49ee733ba
thanks, once the patch is merged to 1.3T branch, please change status-b2g-v1.3T to fixed
Flags: needinfo?(jcheng)

Updated

5 years ago
status-b2g-v1.3T: affected → fixed
Flags: needinfo?(ying.xu)
You need to log in before you can comment on or make changes to this bug.