937332 - Suppress some of the js/jsm/test file name output going to stdout

Status: NEW

(Firefox Build System :: General, defect)

Description

[(no longer active)]

So I used to get build times around 20+/-1 min builds on my machine, and starting this morning, the build time has gone up to 27 minutes.

I noticed that the build system has started to spam the stdout a lot with messages printing things such as js/jsm/test file names.  I don't know why this happened, but given that all terminal applications are horribly slow, I tried comparing the build times between a |./mach build| and a |./mach build 2>&1 >/dev/null|.  On Mac, with iTerm2, the build time goes down by around 4 minutes.

Given how slow the cmd.exe terminal is, this is especially painful on Windows.

Can we please suppress this additional console output by default?

Comment 1

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ad04a01e825

Comment 2

[Gregory Szorc [:gps]]

A little over 2 years ago I noticed that Terminal.app (the built-in terminal on OS X) was about 30s slower than iTerm2. Terminal spew causing build slowness is a known issue. It's a big reason why local builds now build in silent mode by default.

I didn't realize the Windows terminal was that slow as well. Not surprising though. I wonder if shipping another terminal (bug 505582) will help. CC RyanVM.

Comment 3

[(no longer active)]

(In reply to Mike Hommey [:glandium] from comment #1)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/6ad04a01e825

Thanks!

(In reply to Gregory Szorc [:gps] from comment #2)
> A little over 2 years ago I noticed that Terminal.app (the built-in terminal
> on OS X) was about 30s slower than iTerm2. Terminal spew causing build
> slowness is a known issue. It's a big reason why local builds now build in
> silent mode by default.

Makes sense.  Speaking of which, is there a good reason to output .o file names, etc by default?

> I didn't realize the Windows terminal was that slow as well. Not surprising
> though. I wonder if shipping another terminal (bug 505582) will help. CC
> RyanVM.

The Windows terminal is the slowest terminal that I've ever seen.  I don't remember exact numbers but its slow down factor is way above 100% if you spam it enough.

Comment 4

[Mike Hommey [:glandium]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> (In reply to Mike Hommey [:glandium] from comment #1)
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/6ad04a01e825
> 
> Thanks!
> 
> (In reply to Gregory Szorc [:gps] from comment #2)
> > A little over 2 years ago I noticed that Terminal.app (the built-in terminal
> > on OS X) was about 30s slower than iTerm2. Terminal spew causing build
> > slowness is a known issue. It's a big reason why local builds now build in
> > silent mode by default.
> 
> Makes sense.  Speaking of which, is there a good reason to output .o file
> names, etc by default?

Besides knowing what the build is doing, not much. If you really want them gone, you can add:

mk_add_options "export REPORT_BUILD="

to your mozconfig.

Comment 5

[Mike Hommey [:glandium]]

Note, we could reasonably skip these lines when we build without -s.