Closed Bug 937369 Opened 6 years ago Closed 6 years ago

[AccessFu] Migrate jsat to moz.build

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Looks like we are still using Makefile.in, I don't think we need to.
Attachment #830469 - Flags: review?(gps)
Comment on attachment 830469 [details] [diff] [review]
Use moz.build in accessibility/src/jsat

Review of attachment 830469 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/moz.build
@@ +9,5 @@
> +EXTRA_JS_MODULES += [
> +    'AccessFu.jsm',
> +    'EventManager.jsm',
> +    'jar.mn',
> +    'Makefile.in',

Why are jar.mn and Makefile.in in this list? I think if they are removed, things will continue to work just fine.
Attachment #830469 - Flags: review?(gps) → feedback+
Attachment #830469 - Attachment is obsolete: true
Attachment #832506 - Flags: review?(dbolter)
Comment on attachment 832506 [details] [diff] [review]
Use moz.build in accessibility/src/jsat

Review of attachment 832506 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. I'm not too familiar with mozbuild but it looks like you did as Gregory asked so that's good enough for me.
Attachment #832506 - Flags: review?(dbolter) → review+
Assignee: nobody → eitan
https://hg.mozilla.org/mozilla-central/rev/fcb819355580
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.