937443 - [Settings] Button wording

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Harly Hsu[:harly]]

List button should use sentence case (Capitalize the first letter of the first word and the first letter of any proper nouns)

Comment 1

[Harly Hsu[:harly]]

1. Settings->Internet sharing->Hotspot settings->Security: "open" should be "Open"
2. Settings->Sound: "Sent Mail" "Sent Message" should be "Sent mail" "Sent message"
3. Settings->Display->Screen timeout: "never" should be "Never"
4. Settings->Keyboard: "Built-in Keyboard" and "Gaia Test Keyboard" should be "Built-in keyboard" and "Gaia test keyboard"
5. Settings->Screen lock: "Lock Screen" should be "Lock screen"
6. Settings->Device information: "More Information" "Your Rights" "Your Privacy" "Legal Information"should be "More information" "Your rights" "Your privacy" "Legal information"
7. Settings->Device information->More Information: "Reset Phone" should be "Reset phone"
8. Settings->Device information->Legal Information: "Open Source Notices" and "Obtaining Source Code" should be "Open source notice" and "Obtaining source code"
9. Settings->Battery: "never" should be "Never"
10. Settings->Improve Firefox OS: "Send Mozilla Feedback" should be "Send Mozilla feedback"
11. Settings->Improve Firefox OS->Submit Your Feedback->Happy: "Send Feedback" should be "Send feedback"
12. Settings->Improve Firefox OS->Submit Your Feedback->Sad: "Send Feedback" should be "Send feedback"

Comment 2

[Anirudh S [:anirudh24seven]]

Attachment: Pull request for fix

This is my first patch for Firefox OS. Excited!

Comment 3

[Anirudh S [:anirudh24seven]]

Attachment: Correct Pull request for fix

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Harly, should we use 'Open source notice' or 'Open source notices'?

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8340871 [details] [diff] [review]
Correct Pull request for fix

anirudh, thanks for your contribution. The patch looks good to me. However, please only keep the commits related to this bug in the pull request. In this bug it would be this one (https://github.com/anirudh24seven/gaia/commit/ba80aad306ce1d7c023d0bcf51438d610fabe1da).

Please request a review again after fixing it, thanks!

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

And note that the commit message should follow the format "Bug number - your message".

Comment 7

[Harly Hsu[:harly]]

Hi Authur,
Yes, it is listed #8 in my list.

(In reply to Arthur Chen [:arthurcc] from comment #4)
> Harly, should we use 'Open source notice' or 'Open source notices'?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks Harly, just double confirm it.

Francesco, do we need to use a new l10n id when changing from "Open source notice" to "Open source notices"?

Comment 9

[Harly Hsu[:harly]]

Sorry for the misunderstanding here,
after discussing with Arthur offline,
we don't need to change from "Open source notices" to "Open source notice"
thanks

(In reply to Arthur Chen [:arthurcc] from comment #8)
> Thanks Harly, just double confirm it.
> 
> Francesco, do we need to use a new l10n id when changing from "Open source
> notice" to "Open source notices"?

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Clear ni? per comment 9.

Comment 11

[Anirudh S [:anirudh24seven]]

Attachment: Updated pull request

The previous pull request did not have the fix in a single commit.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8355061 [details] [review]
Updated pull request

Thanks for the patch. I found it now conflicts to master. Could you resolve the conflict? P.S. please use the format "Bug 937443 - ......." for the commit message.

Comment 13

[u482081]

Does anyone mind if I pick up where anirudh left off? I can't tell if he's still actively working on this.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Anirudh, are you available working on this bug?

Comment 15

[Anirudh S [:anirudh24seven]]

I am not actively working on this. Kevin, you can pick it up.

Comment 16

[kumar rishav (:rishav_)]

Hi Arthur
I am interested to work on this bug.Can you assign this to me?
Thanks

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Kumar, thank you for willing to take this. However, per comment 13, Kevin may already start working on this.

Kevin, are you working on this bug?

Comment 18

[u482081]

Yes I am. I should be filing a pull request tomorrow.

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Please rebase to the current master as we just land bug 936398 and the patch may already cover some of the strings to be modified here. Thanks!

Comment 20

[u482081]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15737

Alright, everything should be in order.

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8366109 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15737

Thanks for the patch, Kevin!

However, after confirmed with the UX designer, we may change the rule within these weeks. So I would suggest to wait for the new rules and close this bug for now. We will open corresponding bugs after the new rules confirmed.