937464 - No mouse cursor when connected mouse.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

I found there is no mouse cursor when connected mouse, but the event of mouse looks normal due to click still works.

The suggested behavior should be mouse cursor is shown when connected mouse, disappear when disconnected mouse.

Below is the SW information:
Gaia: 37ad831cfde9e5b88f3e330e3a4e47b7df85b41c
Gecko: 1b73d5648bb71cad92915a7bf4120361b94dd31a
Version=28.0a1
BuildID=20131111175310

Comment 1

[nguyenthanh.trung]

Attachment: Add a mouse cursor

This patch is based on the patch "Draw a pink square in B2G for testing, v2" in https://bugzilla.mozilla.org/show_bug.cgi?id=781039. But here, an image is used for the cursor and the cursor is only shown after the first time the mouse is moved.

Comment 2

[Danny Liang [:dliang]]

Hi Nguyenthanh,
Thanks for sharing, the patch works fine on TV box with mouse connected, the mouse cursor is shown successfully.
I also tried your patch on other mobile devices, the mouse cursor is also shown even if it doesn't connect mouse. It does not meet our expectation and we might need to think more before submit.
Best regards,

Comment 3

[nguyenthanh.trung]

(In reply to Danny Liang [:dannyliang] from comment #2)
> Hi Nguyenthanh,
> Thanks for sharing, the patch works fine on TV box with mouse connected, the
> mouse cursor is shown successfully.
> I also tried your patch on other mobile devices, the mouse cursor is also
> shown even if it doesn't connect mouse. It does not meet our expectation and
> we might need to think more before submit.
> Best regards,

Okay, I only have APC 8950 board here, but not any other FirefoxOS-able device so I have never though about that :)

Comment 4

[nguyenthanh.trung]

Attachment: 0001-MouseController-MouseCursor.patch

I created a new patch for this. This will show the cursor only if having a mouse connected. Please check if it is okay & if it works for your other devices :)

Comment 5

[nguyenthanh.trung]

(In reply to nguyenthanh.trung from comment #4)
> Created attachment 8403100 [details] [diff] [review]
> 0001-MouseController-MouseCursor.patch
> 
> I created a new patch for this. This will show the cursor only if having a
> mouse connected. Please check if it is okay & if it works for your other
> devices :)

P/S: The gecko master commit I used here is 77f31d4d20c (Mar 11 2014)

Comment 6

[Joe Young]

Attachment: 0001-patch-mouse-cursor-from-Bug-937464.patch

In new version of Gecko, 
The Macro(NS_IMPL_ISUPPORTS1) that is used in nsMouseController.cpp.
Need to change from NS_IMPL_ISUPPORTS1() to NS_IMPL_ISUPPORTS().

Comment 7

[BMO Automation]

Firefox OS is not being worked on