Closed Bug 937466 Opened 6 years ago Closed 6 years ago

[AccessFu] Add constants module

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

We have a lot of constants between roles events and other types. We talked before about adding a stand-alone module that auto-populates a name->integer mapping.
Attachment #830622 - Flags: review?(yura.zenevich)
Comment on attachment 830622 [details] [diff] [review]
Introduce Constants module.

Review of attachment 830622 [details] [diff] [review]:
-----------------------------------------------------------------

Looks much cleaner! r=me with that one change.

::: accessible/src/jsat/TraversalRules.jsm
@@ +10,5 @@
>  const Cr = Components.results;
>  
>  const FILTER_IGNORE = Ci.nsIAccessibleTraversalRule.FILTER_IGNORE;
>  const FILTER_MATCH = Ci.nsIAccessibleTraversalRule.FILTER_MATCH;
>  const FILTER_IGNORE_SUBTREE = Ci.nsIAccessibleTraversalRule.FILTER_IGNORE_SUBTREE;

Since Filters is in Constants, this should be updated as well.
Attachment #830622 - Flags: review?(yura.zenevich) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/550a02fca7b3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → eitan
(Bugs aren't resolved until they hit m-c)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/b8053dd037bc
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.